module: remove experimental warning from type stripping

PR-URL: #58643
Backport-PR-URL: #57298
Refs: nodejs/typescript#24
Reviewed-By: Jacob Smith <jacob@frende.me>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Filip Skokan <panva.ip@gmail.com>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Chemi Atlow <chemi@atlow.co.il>
PR-URL: #56350Fixes: nodejs/typescript#17

Author: marco-ippolito

doc/api/typescript.md

@@ -2,6 +2,9 @@
 
 <!-- YAML
 changes:
+ - version: REPLACEME
+ pr-url: https://github.com/nodejs/node/pull/58643
+ description: Type stripping no longer emits an experimental warning.
  - version: REPLACEME
  pr-url: https://github.com/nodejs/node/pull/56350
  description: Type stripping is enabled by default.

lib/internal/modules/typescript.js

@@ -28,7 +28,8 @@ const { Buffer } = require('buffer');
  * @type {string}
  */
 constgetTypeScriptParsingMode=getLazy(()=>
-(getOptionValue('--experimental-transform-types') ? 'transform' : 'strip-only'),
+(getOptionValue('--experimental-transform-types') ?
+(emitExperimentalWarning('Transform Types'),'transform') : 'strip-only'),
 );
 
 /**
@@ -131,13 +132,9 @@ function processTypeScriptCode(code, options) {
  * It is used by internal loaders.
  * @param {string} source TypeScript code to parse.
  * @param {string} filename The filename of the source code.
- * @param {boolean} emitWarning Whether to emit a warning.
  * @returns {TransformOutput} The stripped TypeScript code.
  */
-functionstripTypeScriptModuleTypes(source,filename,emitWarning=true){
-if(emitWarning){
-emitExperimentalWarning('Type Stripping');
-}
+functionstripTypeScriptModuleTypes(source,filename){
 assert(typeofsource==='string');
 if(isUnderNodeModules(filename)){
 thrownewERR_UNSUPPORTED_NODE_MODULES_TYPE_STRIPPING(filename);

lib/internal/process/execution.js

@@ -35,7 +35,6 @@ const { getOptionValue } = require('internal/options');
 const{
  makeContextifyScript, runScriptInThisContext,
 }=require('internal/vm');
-const{ emitExperimentalWarning }=require('internal/util');
 // shouldAbortOnUncaughtToggle is a typed array for faster
 // communication with JS.
 const{ shouldAbortOnUncaughtToggle }=internalBinding('util');
@@ -255,16 +254,14 @@ function evalTypeScript(name, source, breakFirstLine, print, shouldLoadESM = fal
 compiledScript=compileScript(name,source,baseUrl);
 }catch(originalError){
 try{
-sourceToRun=stripTypeScriptModuleTypes(source,name,false);
+sourceToRun=stripTypeScriptModuleTypes(source,kEvalTag);
 // Retry the CJS/ESM syntax detection after stripping the types.
 if(shouldUseModuleEntryPoint(name,sourceToRun)){
 returnevalTypeScriptModuleEntryPoint(source,print);
 }
 // If the ContextifiedScript was successfully created, execute it.
 // outside the try-catch block to avoid catching runtime errors.
 compiledScript=compileScript(name,sourceToRun,baseUrl);
-// Emit the experimental warning after the code was successfully evaluated.
-emitExperimentalWarning('Type Stripping');
 }catch(tsError){
 // If it's invalid or unsupported TypeScript syntax, rethrow the original error
 // with the TypeScript error message added to the stack.
@@ -318,12 +315,10 @@ function evalTypeScriptModuleEntryPoint(source, print) {
 moduleWrap=loader.createModuleWrap(source,url);
 }catch(originalError){
 try{
-conststrippedSource=stripTypeScriptModuleTypes(source,url,false);
+conststrippedSource=stripTypeScriptModuleTypes(source,kEvalTag);
 // If the moduleWrap was successfully created, execute the module job.
 // outside the try-catch block to avoid catching runtime errors.
 moduleWrap=loader.createModuleWrap(strippedSource,url);
-// Emit the experimental warning after the code was successfully compiled.
-emitExperimentalWarning('Type Stripping');
 }catch(tsError){
 // If it's invalid or unsupported TypeScript syntax, rethrow the original error
 // with the TypeScript error message added to the stack.

test/es-module/test-typescript-eval.mjs

@@ -11,7 +11,7 @@ test('eval TypeScript ESM syntax', async () => {
  const text: string = 'Hello, TypeScript!'
  console.log(util.styleText('red', text));`]);
 
-match(result.stderr,/TypeStrippingisanexperimentalfeatureandmightchangeatanytime/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });
@@ -24,7 +24,7 @@ test('eval TypeScript ESM syntax with input-type module', async () => {
  const text: string = 'Hello, TypeScript!'
  console.log(util.styleText('red', text));`]);
 
-match(result.stderr,/TypeStrippingisanexperimentalfeatureandmightchangeatanytime/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });
@@ -36,7 +36,7 @@ test('eval TypeScript CommonJS syntax', async () => {
  const text: string = 'Hello, TypeScript!'
  console.log(util.styleText('red', text));`]);
 match(result.stdout,/Hello,TypeScript!/);
-match(result.stderr,/ExperimentalWarning:TypeStrippingisanexperimental/);
+strictEqual(result.stderr,'');
 strictEqual(result.code,0);
 });
 
@@ -72,7 +72,7 @@ test('TypeScript ESM syntax not specified', async () => {
 `import util from 'node:util'
  const text: string = 'Hello, TypeScript!'
  console.log(text);`]);
-match(result.stderr,/ExperimentalWarning:TypeStrippingisanexperimental/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });
@@ -162,7 +162,7 @@ test('check warning is emitted when eval TypeScript CommonJS syntax', async () =
 `const util = require('node:util');
  const text: string = 'Hello, TypeScript!'
  console.log(util.styleText('red', text));`]);
-match(result.stderr,/ExperimentalWarning:TypeStrippingisanexperimental/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });

test/es-module/test-typescript-module.mjs

@@ -20,7 +20,7 @@ test('execute an .mts file importing an .mts file', async () => {
 fixtures.path('typescript/mts/test-import-module.mts'),
 ]);
 
-match(result.stderr,/TypeStrippingisanexperimentalfeatureandmightchangeatanytime/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });

test/es-module/test-typescript.mjs

@@ -35,7 +35,7 @@ test('execute a TypeScript file', async () => {
 fixtures.path('typescript/ts/test-typescript.ts'),
 ]);
 
-match(result.stderr,/TypeStrippingisanexperimentalfeatureandmightchangeatanytime/);
+strictEqual(result.stderr,'');
 match(result.stdout,/Hello,TypeScript!/);
 strictEqual(result.code,0);
 });
@@ -412,3 +412,14 @@ test('execute invalid TypeScript syntax', async () => {
 strictEqual(result.stdout,'');
 strictEqual(result.code,1);
 });
+
+test('check transform types warning',async()=>{
+constresult=awaitspawnPromisified(process.execPath,[
+'--experimental-transform-types',
+fixtures.path('typescript/ts/test-typescript.ts'),
+]);
+
+match(result.stderr,/TransformTypesisanexperimentalfeatureandmightchangeatanytime/);
+match(result.stdout,/Hello,TypeScript!/);
+strictEqual(result.code,0);
+});