Skip to content

Commit ca53866

Browse files
tmeisenhMylesBorins
authored andcommitted
test: add message verification on assert.throws
Add regular expression for error message validation to instances of assert.throws() in test-assert.js. PR-URL: #10890 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent 38b123c commit ca53866

1 file changed

Lines changed: 10 additions & 5 deletions

File tree

‎test/parallel/test-assert.js‎

Lines changed: 10 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -90,11 +90,16 @@ assert.doesNotThrow(makeBlock(a.deepEqual, /a/g, /a/g));
9090
assert.doesNotThrow(makeBlock(a.deepEqual,/a/i,/a/i));
9191
assert.doesNotThrow(makeBlock(a.deepEqual,/a/m,/a/m));
9292
assert.doesNotThrow(makeBlock(a.deepEqual,/a/igm,/a/igm));
93-
assert.throws(makeBlock(a.deepEqual,/ab/,/a/));
94-
assert.throws(makeBlock(a.deepEqual,/a/g,/a/));
95-
assert.throws(makeBlock(a.deepEqual,/a/i,/a/));
96-
assert.throws(makeBlock(a.deepEqual,/a/m,/a/));
97-
assert.throws(makeBlock(a.deepEqual,/a/igm,/a/im));
93+
assert.throws(makeBlock(a.deepEqual,/ab/,/a/),
94+
/^AssertionError:\/ab\/deepEqual\/a\/$/);
95+
assert.throws(makeBlock(a.deepEqual,/a/g,/a/),
96+
/^AssertionError:\/a\/gdeepEqual\/a\/$/);
97+
assert.throws(makeBlock(a.deepEqual,/a/i,/a/),
98+
/^AssertionError:\/a\/ideepEqual\/a\/$/);
99+
assert.throws(makeBlock(a.deepEqual,/a/m,/a/),
100+
/^AssertionError:\/a\/mdeepEqual\/a\/$/);
101+
assert.throws(makeBlock(a.deepEqual,/a/igm,/a/im),
102+
/^AssertionError:\/a\/gimdeepEqual\/a\/im$/);
98103

99104
{
100105
constre1=/a/g;

0 commit comments

Comments
 (0)