cluster: refactor empty for in round_robin_handle.js

gengjiawen · BridgeAR · commit cba23ed92ae0 · 2019-03-14T17:15:30.000+01:00
PR-URL: #26560 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/cluster/round_robin_handle.js b/lib/internal/cluster/round_robin_handle.js
@@ -79,8 +79,10 @@ RoundRobinHandle.prototype.remove = function(worker) {
 if (this.all.size !== 0)
 return false;
 
- for (var handle; handle = this.handles.shift(); handle.close())
- ;
+ for (const handle of this.handles) {
+ handle.close();
+ }
+ this.handles = [];
 
 this.handle.close();
 this.handle = null;

-Original file line number
+Diff line change
 if(this.all.size!==0)
 returnfalse;
 -for(varhandle;handle=this.handles.shift();handle.close())
 -;
 +for(consthandleofthis.handles){
 +handle.close();
 +}
 +this.handles=[];
 this.handle.close();
 this.handle=null;