Skip to content

Commit cbe77b3

Browse files
anonrigaduh95
authored andcommitted
lib: move ToNamespacedPath call to c++
PR-URL: #53654 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
1 parent 5aa2163 commit cbe77b3

2 files changed

Lines changed: 3 additions & 6 deletions

File tree

‎lib/internal/modules/esm/formats.js‎

Lines changed: 1 addition & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -6,7 +6,6 @@ const {
66

77
const{ getOptionValue }=require('internal/options');
88
const{ getValidatedPath }=require('internal/fs/utils');
9-
constpathModule=require('path');
109
constfsBindings=internalBinding('fs');
1110
const{fs: fsConstants}=internalBinding('constants');
1211

@@ -48,9 +47,7 @@ function mimeToFormat(mime) {
4847
*/
4948
functiongetFormatOfExtensionlessFile(url){
5049
if(!experimentalWasmModules){return'module';}
51-
52-
constpath=pathModule.toNamespacedPath(getValidatedPath(url));
53-
50+
constpath=getValidatedPath(url);
5451
switch(fsBindings.getFormatOfExtensionlessFile(path)){
5552
casefsConstants.EXTENSIONLESS_FORMAT_WASM:
5653
return'wasm';

‎src/node_file.cc‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2966,8 +2966,8 @@ static void GetFormatOfExtensionlessFile(
29662966
CHECK(args[0]->IsString());
29672967

29682968
Environment* env = Environment::GetCurrent(args);
2969-
node::Utf8Valueinput(args.GetIsolate(), args[0]);
2970-
2969+
BufferValueinput(args.GetIsolate(), args[0]);
2970+
ToNamespacedPath(env, &input);
29712971
THROW_IF_INSUFFICIENT_PERMISSIONS(
29722972
env, permission::PermissionScope::kFileSystemRead, input.ToStringView());
29732973

0 commit comments

Comments
 (0)