http: fixes memory retention issue with FreeList and HTTPParser

Fixes: #29394
Refs: #33167 (comment)
PR-URL: #33190
Reviewed-By: Robert Nagy <ronagy@icloud.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>

Author: leidegre

lib/_http_common.js

@@ -161,12 +161,10 @@ const parsers = new FreeList('parsers', 1000, function parsersCb() {
 
 cleanParser(parser);
 
-parser.onIncoming=null;
 parser[kOnHeaders]=parserOnHeaders;
 parser[kOnHeadersComplete]=parserOnHeadersComplete;
 parser[kOnBody]=parserOnBody;
 parser[kOnMessageComplete]=parserOnMessageComplete;
-parser[kOnTimeout]=null;
 
 returnparser;
 });
@@ -232,7 +230,9 @@ function cleanParser(parser) {
 parser.outgoing=null;
 parser.maxHeaderPairs=MAX_HEADER_PAIRS;
 parser[kOnExecute]=null;
+parser[kOnTimeout]=null;
 parser._consumed=false;
+parser.onIncoming=null;
 }
 
 functionprepareError(err,parser,rawPacket){

test/parallel/test-http-parser-memory-retention.js

@@ -0,0 +1,42 @@
+'use strict';
+
+constcommon=require('../common');
+constassert=require('assert');
+consthttp=require('http');
+const{ HTTPParser }=require('_http_common');
+
+// Test that the `HTTPParser` instance is cleaned up before being returned to
+// the pool to avoid memory retention issues.
+
+constkOnTimeout=HTTPParser.kOnTimeout|0;
+constserver=http.createServer();
+
+server.on('request',common.mustCall((request,response)=>{
+constparser=request.socket.parser;
+
+assert.strictEqual(typeofparser[kOnTimeout],'function');
+
+request.socket.on('close',common.mustCall(()=>{
+assert.strictEqual(parser[kOnTimeout],null);
+}));
+
+response.end();
+server.close();
+}));
+
+server.listen(common.mustCall(()=>{
+constrequest=http.get({port: server.address().port});
+letparser;
+
+request.on('socket',common.mustCall(()=>{
+parser=request.parser;
+assert.strictEqual(typeofparser.onIncoming,'function');
+}));
+
+request.on('response',common.mustCall((response)=>{
+response.resume();
+response.on('end',common.mustCall(()=>{
+assert.strictEqual(parser.onIncoming,null);
+}));
+}));
+}));