test: fix test-watch-mode-inspect

StefanStojanovic · targos · commit cd36250fcb6d · 2022-12-12T16:17:47.000Z
Refs: #44898 PR-URL: #45586 Reviewed-By: Moshe Atlow <moshe@atlow.co.il> Reviewed-By: Erick Wendel <erick.workspace@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/test/sequential/test-watch-mode-inspect.mjs b/test/sequential/test-watch-mode-inspect.mjs
@@ -12,26 +12,34 @@ if (common.isIBMi)
 
 common.skipIfInspectorDisabled();
 
+let gettingDebuggedPid = false;
+
+async function getDebuggedPid(instance, waitForLog = true) {
+ gettingDebuggedPid = true;
+ const session = await instance.connectInspectorSession();
+ await session.send({ method: 'Runtime.enable' });
+ if (waitForLog) {
+ await session.waitForConsoleOutput('log', 'safe to debug now');
+ }
+ const { value: innerPid } = (await session.send({
+ 'method': 'Runtime.evaluate', 'params': { 'expression': 'process.pid' }
+ })).result;
+ session.disconnect();
+ gettingDebuggedPid = false;
+ return innerPid;
+}
+
 function restart(file) {
 writeFileSync(file, readFileSync(file));
- const interval = setInterval(() => writeFileSync(file, readFileSync(file)), 500);
+ const interval = setInterval(() => {
+ if (!gettingDebuggedPid) {
+ writeFileSync(file, readFileSync(file));
+ }
+ }, common.platformTimeout(500));
 return () => clearInterval(interval);
 }
 
 describe('watch mode - inspect', () => {
- async function getDebuggedPid(instance, waitForLog = true) {
- const session = await instance.connectInspectorSession();
- await session.send({ method: 'Runtime.enable' });
- if (waitForLog) {
- await session.waitForConsoleOutput('log', 'safe to debug now');
- }
- const { value: innerPid } = (await session.send({
- 'method': 'Runtime.evaluate', 'params': { 'expression': 'process.pid' }
- })).result;
- session.disconnect();
- return innerPid;
- }
-
 it('should start debugger on inner process', async () => {
 const file = fixtures.path('watch-mode/inspect.js');
 const instance = new NodeInstance(['--inspect=0', '--watch'], undefined, file);

-Original file line number
+Diff line change
 common.skipIfInspectorDisabled();
 +letgettingDebuggedPid=false;
++
 +asyncfunctiongetDebuggedPid(instance,waitForLog=true){
 +gettingDebuggedPid=true;
 +constsession=awaitinstance.connectInspectorSession();
 +awaitsession.send({method: 'Runtime.enable'});
 +if(waitForLog){
 +awaitsession.waitForConsoleOutput('log','safe to debug now');
 +}
 +const{value: innerPid}=(awaitsession.send({
 +'method': 'Runtime.evaluate','params': {'expression': 'process.pid'}
 +})).result;
 +session.disconnect();
 +gettingDebuggedPid=false;
 +returninnerPid;
 +}
++
 functionrestart(file){
 writeFileSync(file,readFileSync(file));
 -constinterval=setInterval(()=>writeFileSync(file,readFileSync(file)),500);
 +constinterval=setInterval(()=>{
 +if(!gettingDebuggedPid){
 +writeFileSync(file,readFileSync(file));
 +}
 +},common.platformTimeout(500));
 return()=>clearInterval(interval);
+}
 describe('watch mode - inspect',()=>{
 -asyncfunctiongetDebuggedPid(instance,waitForLog=true){
 -constsession=awaitinstance.connectInspectorSession();
 -awaitsession.send({method: 'Runtime.enable'});
 -if(waitForLog){
 -awaitsession.waitForConsoleOutput('log','safe to debug now');
 -}
 -const{value: innerPid}=(awaitsession.send({
 -'method': 'Runtime.evaluate','params': {'expression': 'process.pid'}
 -})).result;
 -session.disconnect();
 -returninnerPid;
 -}
+-
 it('should start debugger on inner process',async()=>{
 constfile=fixtures.path('watch-mode/inspect.js');
 constinstance=newNodeInstance(['--inspect=0','--watch'],undefined,file);