test: handle relative https redirect

richardlau · richardlau · commit cd613e5167a3 · 2024-03-20T15:48:02.000Z
Fix `internet/test-inspector-help-page` to handle the relative redirect of `https://nodejs.org/en/docs/inspector` to `/en/docs/guides/debugging-getting-started`. Previously this URL redirected to an absolute URL. PR-URL: #51121 Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io>
diff --git a/test/internet/test-inspector-help-page.js b/test/internet/test-inspector-help-page.js
@@ -18,7 +18,7 @@ function check(url, cb) {
 assert(res.statusCode >= 200 && res.statusCode < 400);
 
 if (res.statusCode >= 300)
- return check(res.headers.location, cb);
+ return check(new URL(res.headers.location, url), cb);
 
 let result = '';
 

-Original file line number
+Diff line change
 assert(res.statusCode>=200&&res.statusCode<400);
 if(res.statusCode>=300)
 -returncheck(res.headers.location,cb);
 +returncheck(newURL(res.headers.location,url),cb);
 letresult='';