tls: for...of in _tls_common.js

PR-URL: #30961
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>

Author: trivikr

lib/_tls_common.js

@@ -100,15 +100,12 @@ exports.createSecureContext = function createSecureContext(options) {
 
 constc=newSecureContext(options.secureProtocol,secureOptions,
 options.minVersion,options.maxVersion);
-leti;
-letval;
 
 // Add CA before the cert to be able to load cert's issuer in C++ code.
 const{ ca }=options;
 if(ca){
 if(ArrayIsArray(ca)){
-for(i=0;i<ca.length;++i){
-val=ca[i];
+for(constvalofca){
 validateKeyOrCertOption('ca',val);
 c.context.addCACert(val);
 }
@@ -123,8 +120,7 @@ exports.createSecureContext = function createSecureContext(options) {
 const{ cert }=options;
 if(cert){
 if(ArrayIsArray(cert)){
-for(i=0;i<cert.length;++i){
-val=cert[i];
+for(constvalofcert){
 validateKeyOrCertOption('cert',val);
 c.context.setCert(val);
 }
@@ -142,8 +138,7 @@ exports.createSecureContext = function createSecureContext(options) {
 constpassphrase=options.passphrase;
 if(key){
 if(ArrayIsArray(key)){
-for(i=0;i<key.length;++i){
-val=key[i];
+for(constvalofkey){
 // eslint-disable-next-line eqeqeq
 constpem=(val!=undefined&&val.pem!==undefined ? val.pem : val);
 validateKeyOrCertOption('key',pem);
@@ -242,8 +237,8 @@ exports.createSecureContext = function createSecureContext(options) {
 
 if(options.crl){
 if(ArrayIsArray(options.crl)){
-for(i=0;i<options.crl.length;i++){
-c.context.addCRL(options.crl[i]);
+for(constcrlofoptions.crl){
+c.context.addCRL(crl);
 }
 }else{
 c.context.addCRL(options.crl);
@@ -259,8 +254,7 @@ exports.createSecureContext = function createSecureContext(options) {
 toBuf=require('internal/crypto/util').toBuf;
 
 if(ArrayIsArray(options.pfx)){
-for(i=0;i<options.pfx.length;i++){
-constpfx=options.pfx[i];
+for(constpfxofoptions.pfx){
 constraw=pfx.buf ? pfx.buf : pfx;
 constbuf=toBuf(raw);
 constpassphrase=pfx.passphrase||options.passphrase;

lib/_tls_wrap.js

@@ -530,9 +530,9 @@ function makeMethodProxy(name) {
 returnthis._parent[name].apply(this._parent,args);
 };
 }
-for(letn=0;n<proxiedMethods.length;n++){
-tls_wrap.TLSWrap.prototype[proxiedMethods[n]]=
-makeMethodProxy(proxiedMethods[n]);
+for(constproxiedMethodofproxiedMethods){
+tls_wrap.TLSWrap.prototype[proxiedMethod]=
+makeMethodProxy(proxiedMethod);
 }
 
 tls_wrap.TLSWrap.prototype.close=functionclose(cb){
@@ -1412,8 +1412,7 @@ Server.prototype[EE.captureRejectionSymbol] = function(
 functionSNICallback(servername,callback){
 constcontexts=this.server._contexts;
 
-for(leti=0;i<contexts.length;i++){
-constelem=contexts[i];
+for(constelemofcontexts){
 if(elem[0].test(servername)){
 callback(null,elem[1]);
 return;

lib/internal/tls.js

@@ -9,12 +9,11 @@ const {
 // C=US\nST=CA\nL=SF\nO=Joyent\nOU=Node.js\nCN=ca1\nemailAddress=ry@clouds.org
 functionparseCertString(s){
 constout=ObjectCreate(null);
-constparts=s.split('\n');
-for(leti=0,len=parts.length;i<len;i++){
-constsepIndex=parts[i].indexOf('=');
+for(constpartofs.split('\n')){
+constsepIndex=part.indexOf('=');
 if(sepIndex>0){
-constkey=parts[i].slice(0,sepIndex);
-constvalue=parts[i].slice(sepIndex+1);
+constkey=part.slice(0,sepIndex);
+constvalue=part.slice(sepIndex+1);
 if(keyinout){
 if(!ArrayIsArray(out[key])){
 out[key]=[out[key]];