util: improve performance of function areSimilarFloatArrays

Septa2112 · RafaelGSS · commit cd891b37f654 · 2023-12-15T15:26:23.000-03:00
Improve performance of areSimilarFloatArrays by using primordial. Refs: #50621 PR-URL: #51040 Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Vinícius Lourenço Claro Cardoso <contact@viniciusl.com.br> Reviewed-By: James M Snell <jasnell@gmail.com>
diff --git a/lib/internal/util/comparisons.js b/lib/internal/util/comparisons.js
@@ -21,6 +21,7 @@ const {
 StringPrototypeValueOf,
 SymbolPrototypeValueOf,
 TypedArrayPrototypeGetSymbolToStringTag,
+ TypedArrayPrototypeGetByteLength,
 Uint8Array,
 } = primordials;
 
@@ -71,7 +72,8 @@ function areSimilarFloatArrays(a, b) {
 if (a.byteLength !== b.byteLength) {
 return false;
 }
- for (let offset = 0; offset < a.byteLength; offset++) {
+ const len = TypedArrayPrototypeGetByteLength(a);
+ for (let offset = 0; offset < len; offset++) {
 if (a[offset] !== b[offset]) {
 return false;
 }

-Original file line number
+Diff line change
  StringPrototypeValueOf,
  SymbolPrototypeValueOf,
  TypedArrayPrototypeGetSymbolToStringTag,
 + TypedArrayPrototypeGetByteLength,
  Uint8Array,
 }=primordials;
 if(a.byteLength!==b.byteLength){
 returnfalse;
+}
 -for(letoffset=0;offset<a.byteLength;offset++){
 +constlen=TypedArrayPrototypeGetByteLength(a);
 +for(letoffset=0;offset<len;offset++){
 if(a[offset]!==b[offset]){
 returnfalse;
+}