Skip to content

Commit ceec23e

Browse files
danbevtargos
authored andcommitted
src: remove using directives from spawn_sync.h
I noticed that there were a few using declarations what were unused and instead of just removing them, this commit removes all of them and uses qualified names instead since they are in a header. PR-URL: #21634 Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
1 parent f3c397c commit ceec23e

1 file changed

Lines changed: 15 additions & 27 deletions

File tree

‎src/spawn_sync.h‎

Lines changed: 15 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -29,18 +29,6 @@
2929

3030
namespacenode {
3131

32-
using v8::Array;
33-
using v8::Context;
34-
using v8::FunctionCallbackInfo;
35-
using v8::HandleScope;
36-
using v8::Integer;
37-
using v8::Isolate;
38-
using v8::Local;
39-
using v8::Null;
40-
using v8::Number;
41-
using v8::Object;
42-
using v8::String;
43-
using v8::Value;
4432

4533

4634
classSyncProcessOutputBuffer;
@@ -94,7 +82,7 @@ class SyncProcessStdioPipe {
9482
intStart();
9583
voidClose();
9684

97-
Local<Object> GetOutputAsBuffer(Environment* env) const;
85+
v8::Local<v8::Object> GetOutputAsBuffer(Environment* env) const;
9886

9987
inlineboolreadable() const;
10088
inlineboolwritable() const;
@@ -151,10 +139,10 @@ class SyncProcessRunner {
151139
};
152140

153141
public:
154-
staticvoidInitialize(Local<Object> target,
155-
Local<Value> unused,
156-
Local<Context> context);
157-
staticvoidSpawn(const FunctionCallbackInfo<Value>& args);
142+
staticvoidInitialize(v8::Local<v8::Object> target,
143+
v8::Local<v8::Value> unused,
144+
v8::Local<v8::Context> context);
145+
staticvoidSpawn(constv8::FunctionCallbackInfo<v8::Value>& args);
158146

159147
private:
160148
friendclassSyncProcessStdioPipe;
@@ -164,8 +152,8 @@ class SyncProcessRunner {
164152

165153
inline Environment* env() const;
166154

167-
Local<Object> Run(Local<Value> options);
168-
voidTryInitializeAndRunLoop(Local<Value> options);
155+
v8::Local<v8::Object> Run(v8::Local<v8::Value> options);
156+
voidTryInitializeAndRunLoop(v8::Local<v8::Value> options);
169157
voidCloseHandlesAndDeleteLoop();
170158

171159
voidCloseStdioPipes();
@@ -181,12 +169,12 @@ class SyncProcessRunner {
181169
voidSetError(int error);
182170
voidSetPipeError(int pipe_error);
183171

184-
Local<Object> BuildResultObject();
185-
Local<Array> BuildOutputArray();
172+
v8::Local<v8::Object> BuildResultObject();
173+
v8::Local<v8::Array> BuildOutputArray();
186174

187-
intParseOptions(Local<Value> js_value);
188-
intParseStdioOptions(Local<Value> js_value);
189-
intParseStdioOption(int child_fd, Local<Object> js_stdio_option);
175+
intParseOptions(v8::Local<v8::Value> js_value);
176+
intParseStdioOptions(v8::Local<v8::Value> js_value);
177+
intParseStdioOption(int child_fd, v8::Local<v8::Object> js_stdio_option);
190178

191179
inlineintAddStdioIgnore(uint32_t child_fd);
192180
inlineintAddStdioPipe(uint32_t child_fd,
@@ -195,9 +183,9 @@ class SyncProcessRunner {
195183
uv_buf_t input_buffer);
196184
inlineintAddStdioInheritFD(uint32_t child_fd, int inherit_fd);
197185

198-
staticboolIsSet(Local<Value> value);
199-
intCopyJsString(Local<Value> js_value, constchar** target);
200-
intCopyJsStringArray(Local<Value> js_value, char** target);
186+
staticboolIsSet(v8::Local<v8::Value> value);
187+
intCopyJsString(v8::Local<v8::Value> js_value, constchar** target);
188+
intCopyJsStringArray(v8::Local<v8::Value> js_value, char** target);
201189

202190
staticvoidExitCallback(uv_process_t* handle,
203191
int64_t exit_status,

0 commit comments

Comments
 (0)