deps: update undici to 5.8.1

PR-URL: #44158
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Feng Yu <F3n67u@outlook.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>

Author: nodejs-github-bot

deps/undici/src/docs/best-practices/mocking-request.md

@@ -1,22 +1,22 @@
 # Mocking Request
 
-Undici have its own mocking [utility](../api/MockAgent.md). It allow us to intercept undici HTTP request and return mocked value instead. It can be useful for testing purposes.
+Undici has its own mocking [utility](../api/MockAgent.md). It allow us to intercept undici HTTP requests and return mocked values instead. It can be useful for testing purposes.
 
 Example:
 
 ```js
 // bank.mjs
 import { request } from'undici'
 
-exportasyncfunctionbankTransfer(recepient, amount) {
+exportasyncfunctionbankTransfer(recipient, amount) {
 const { body } =awaitrequest('http://localhost:3000/bank-transfer',
  {
  method:'POST',
  headers: {
 'X-TOKEN-SECRET':'SuperSecretToken',
  },
  body:JSON.stringify({
-recepient,
+recipient,
  amount
  })
  }
@@ -48,7 +48,7 @@ mockPool.intercept({
 'X-TOKEN-SECRET':'SuperSecretToken',
  },
  body:JSON.stringify({
-recepient:'1234567890',
+recipient:'1234567890',
  amount:'100'
  })
 }).reply(200, {
@@ -77,7 +77,7 @@ Explore other MockAgent functionality [here](../api/MockAgent.md)
 
 ## Debug Mock Value
 
-When the interceptor we wrote are not the same undici will automatically call real HTTP request. To debug our mock value use `mockAgent.disableNetConnect()`
+When the interceptor and the request options are not the same, undici will automatically make a real HTTP request. To prevent real requests from being made, use `mockAgent.disableNetConnect()`:
 
 ```js
 constmockAgent=newMockAgent();
@@ -89,7 +89,7 @@ mockAgent.disableNetConnect()
 constmockPool=mockAgent.get('http://localhost:3000');
 
 mockPool.intercept({
- path:'/bank-tanfer',
+ path:'/bank-transfer',
  method:'POST',
 }).reply(200, {
  message:'transaction processed'
@@ -103,7 +103,7 @@ const badRequest = await bankTransfer('1234567890', '100')
 
 ## Reply with data based on request
 
-If the mocked response needs to be dynamically derived from the request parameters, you can provide a function instead of an object to `reply`
+If the mocked response needs to be dynamically derived from the request parameters, you can provide a function instead of an object to `reply`:
 
 ```js
 mockPool.intercept({
@@ -113,7 +113,7 @@ mockPool.intercept({
 'X-TOKEN-SECRET':'SuperSecretToken',
  },
  body:JSON.stringify({
-recepient:'1234567890',
+recipient:'1234567890',
  amount:'100'
  })
 }).reply(200, (opts) => {
@@ -129,7 +129,7 @@ in this case opts will be
 {
  method: 'POST',
  headers: { 'X-TOKEN-SECRET': 'SuperSecretToken' },
- body: '{"recepient":"1234567890","amount":"100"}',
+ body: '{"recipient":"1234567890","amount":"100"}',
  origin: 'http://localhost:3000',
  path: '/bank-transfer'
 }

deps/undici/src/lib/core/connect.js

@@ -75,14 +75,12 @@ function buildConnector ({ maxCachedSessions, socketPath, timeout, ...opts }) {
 })
 }
 
-consttimeoutId=timeout
- ? setTimeout(onConnectTimeout,timeout,socket)
- : null
+constcancelTimeout=setupTimeout(()=>onConnectTimeout(socket),timeout)
 
 socket
 .setNoDelay(true)
 .once(protocol==='https:' ? 'secureConnect' : 'connect',function(){
-clearTimeout(timeoutId)
+cancelTimeout()
 
 if(callback){
 constcb=callback
@@ -91,7 +89,7 @@ function buildConnector ({ maxCachedSessions, socketPath, timeout, ...opts }) {
 }
 })
 .on('error',function(err){
-clearTimeout(timeoutId)
+cancelTimeout()
 
 if(callback){
 constcb=callback
@@ -104,6 +102,31 @@ function buildConnector ({ maxCachedSessions, socketPath, timeout, ...opts }) {
 }
 }
 
+functionsetupTimeout(onConnectTimeout,timeout){
+if(!timeout){
+return()=>{}
+}
+
+lets1=null
+lets2=null
+consttimeoutId=setTimeout(()=>{
+// setImmediate is added to make sure that we priotorise socket error events over timeouts
+s1=setImmediate(()=>{
+if(process.platform==='win32'){
+// Windows needs an extra setImmediate probably due to implementation differences in the socket logic
+s2=setImmediate(()=>onConnectTimeout())
+}else{
+onConnectTimeout()
+}
+})
+},timeout)
+return()=>{
+clearTimeout(timeoutId)
+clearImmediate(s1)
+clearImmediate(s2)
+}
+}
+
 functiononConnectTimeout(socket){
 util.destroy(socket,newConnectTimeoutError())
 }

deps/undici/src/lib/fetch/body.js

@@ -404,7 +404,18 @@ function bodyMixinMethods (instance) {
 // 1. Let entries be the result of parsing bytes.
 letentries
 try{
-entries=newURLSearchParams(awaitthis.text())
+lettext=''
+// application/x-www-form-urlencoded parser will keep the BOM.
+// https://url.spec.whatwg.org/#concept-urlencoded-parser
+consttextDecoder=newTextDecoder('utf-8',{ignoreBOM: true})
+forawait(constchunkofconsumeBody(this[kState].body)){
+if(!isUint8Array(chunk)){
+thrownewTypeError('Expected Uint8Array chunk')
+}
+text+=textDecoder.decode(chunk,{stream: true})
+}
+text+=textDecoder.decode()
+entries=newURLSearchParams(text)
 }catch(err){
 // istanbul ignore next: Unclear when new URLSearchParams can fail on a string.
 // 2. If entries is failure, then throw a TypeError.

deps/undici/src/lib/fetch/dataURL.js

@@ -255,7 +255,7 @@ function percentDecode (input) {
 }
 
 // 3. Return output.
-returnUint8Array.of(...output)
+returnUint8Array.from(output)
 }
 
 // https://mimesniff.spec.whatwg.org/#parse-a-mime-type

deps/undici/src/lib/fetch/index.js

@@ -33,7 +33,8 @@ const {
  isBlobLike,
  sameOrigin,
  isCancelled,
- isAborted
+ isAborted,
+ isErrorLike
 }=require('./util')
 const{ kState, kHeaders, kGuard, kRealm }=require('./symbols')
 constassert=require('assert')
@@ -1854,7 +1855,7 @@ async function httpNetworkFetch (
 timingInfo.decodedBodySize+=bytes?.byteLength??0
 
 // 6. If bytes is failure, then terminate fetchParams’s controller.
-if(bytesinstanceofError){
+if(isErrorLike(bytes)){
 fetchParams.controller.terminate(bytes)
 return
 }
@@ -1894,7 +1895,7 @@ async function httpNetworkFetch (
 // 3. Otherwise, if stream is readable, error stream with a TypeError.
 if(isReadable(stream)){
 fetchParams.controller.controller.error(newTypeError('terminated',{
-cause: reasoninstanceofError ? reason : undefined
+cause: isErrorLike(reason) ? reason : undefined
 }))
 }
 }
@@ -1942,14 +1943,17 @@ async function httpNetworkFetch (
 }
 
 letcodings=[]
+letlocation=''
 
 constheaders=newHeaders()
 for(letn=0;n<headersList.length;n+=2){
-constkey=headersList[n+0].toString()
-constval=headersList[n+1].toString()
+constkey=headersList[n+0].toString('latin1')
+constval=headersList[n+1].toString('latin1')
 
 if(key.toLowerCase()==='content-encoding'){
 codings=val.split(',').map((x)=>x.trim())
+}elseif(key.toLowerCase()==='location'){
+location=val
 }
 
 headers.append(key,val)
@@ -1960,7 +1964,7 @@ async function httpNetworkFetch (
 constdecoders=[]
 
 // https://developer.mozilla.org/en-US/docs/Web/HTTP/Headers/Content-Encoding
-if(request.method!=='HEAD'&&request.method!=='CONNECT'&&!nullBodyStatus.includes(status)){
+if(request.method!=='HEAD'&&request.method!=='CONNECT'&&!nullBodyStatus.includes(status)&&!(request.redirect==='follow'&&location)){
 for(constcodingofcodings){
 if(/(x-)?gzip/.test(coding)){
 decoders.push(zlib.createGunzip())
@@ -1980,7 +1984,7 @@ async function httpNetworkFetch (
  statusText,
 headersList: headers[kHeadersList],
 body: decoders.length
- ? pipeline(this.body, ...decoders,()=>{})
+ ? pipeline(this.body, ...decoders,()=>{})
  : this.body.on('error',()=>{})
 })
 

deps/undici/src/lib/fetch/request.js

@@ -367,9 +367,9 @@ class Request {
 }
 
 if(signal.aborted){
-ac.abort()
+ac.abort(signal.reason)
 }else{
-constabort=()=>ac.abort()
+constabort=()=>ac.abort(signal.reason)
 signal.addEventListener('abort',abort,{once: true})
 requestFinalizer.register(this,{ signal, abort })
 }
@@ -726,12 +726,12 @@ class Request {
 // 4. Make clonedRequestObject’s signal follow this’s signal.
 constac=newAbortController()
 if(this.signal.aborted){
-ac.abort()
+ac.abort(this.signal.reason)
 }else{
 this.signal.addEventListener(
 'abort',
-function(){
-ac.abort()
+()=>{
+ac.abort(this.signal.reason)
 },
 {once: true}
 )

deps/undici/src/lib/fetch/response.js

@@ -10,7 +10,8 @@ const {
  isCancelled,
  isAborted,
  isBlobLike,
- serializeJavascriptValueToJSONString
+ serializeJavascriptValueToJSONString,
+ isErrorLike
 }=require('./util')
 const{
  redirectStatus,
@@ -347,15 +348,15 @@ function makeResponse (init) {
 }
 
 functionmakeNetworkError(reason){
+constisError=isErrorLike(reason)
 returnmakeResponse({
 type: 'error',
 status: 0,
-error:
-reasoninstanceofError
- ? reason
- : newError(reason ? String(reason) : reason,{
-cause: reasoninstanceofError ? reason : undefined
-}),
+error: isError
+ ? reason
+ : newError(reason ? String(reason) : reason,{
+cause: isError ? reason : undefined
+}),
 aborted: reason&&reason.name==='AbortError'
 })
 }

deps/undici/src/lib/fetch/util.js

@@ -82,6 +82,13 @@ function isFileLike (object) {
 )
 }
 
+functionisErrorLike(object){
+returnobjectinstanceofError||(
+object?.constructor?.name==='Error'||
+object?.constructor?.name==='DOMException'
+)
+}
+
 // Check whether |statusText| is a ByteString and
 // matches the Reason-Phrase token production.
 // RFC 2616: https://tools.ietf.org/html/rfc2616
@@ -469,5 +476,6 @@ module.exports = {
  makeIterator,
  isValidHeaderName,
  isValidHeaderValue,
- hasOwn
+ hasOwn,
+ isErrorLike
 }

deps/undici/src/lib/fetch/webidl.js

@@ -388,8 +388,9 @@ webidl.converters.DOMString = function (V, opts = {}) {
 returnString(V)
 }
 
+// Check for 0 or more characters outside of the latin1 range.
 // eslint-disable-next-line no-control-regex
-constisNotLatin1=/[^\u0000-\u00ff]/
+constisLatin1=/^[\u0000-\u00ff]{0,}$/
 
 // https://webidl.spec.whatwg.org/#es-ByteString
 webidl.converters.ByteString=function(V){
@@ -399,7 +400,7 @@ webidl.converters.ByteString = function (V) {
 
 // 2. If the value of any element of x is greater than
 // 255, then throw a TypeError.
-if(isNotLatin1.test(x)){
+if(!isLatin1.test(x)){
 thrownewTypeError('Argument is not a ByteString')
 }
 

deps/undici/src/lib/mock/mock-utils.js

@@ -38,7 +38,7 @@ function lowerCaseEntries (headers) {
 functiongetHeaderByName(headers,key){
 if(Array.isArray(headers)){
 for(leti=0;i<headers.length;i+=2){
-if(headers[i]===key){
+if(headers[i].toLocaleLowerCase()===key.toLocaleLowerCase()){
 returnheaders[i+1]
 }
 }
@@ -47,19 +47,24 @@ function getHeaderByName (headers, key) {
 }elseif(typeofheaders.get==='function'){
 returnheaders.get(key)
 }else{
-returnheaders[key]
+returnlowerCaseEntries(headers)[key.toLocaleLowerCase()]
 }
 }
 
+/** @param {string[]} headers */
+functionbuildHeadersFromArray(headers){// fetch HeadersList
+constclone=headers.slice()
+constentries=[]
+for(letindex=0;index<clone.length;index+=2){
+entries.push([clone[index],clone[index+1]])
+}
+returnObject.fromEntries(entries)
+}
+
 functionmatchHeaders(mockDispatch,headers){
 if(typeofmockDispatch.headers==='function'){
 if(Array.isArray(headers)){// fetch HeadersList
-constclone=headers.slice()
-constentries=[]
-for(letindex=0;index<clone.length;index+=2){
-entries.push([clone[index],clone[index+1]])
-}
-headers=Object.fromEntries(entries)
+headers=buildHeadersFromArray(headers)
 }
 returnmockDispatch.headers(headers ? lowerCaseEntries(headers) : {})
 }
@@ -284,7 +289,13 @@ function mockDispatch (opts, handler) {
 }
 
 functionhandleReply(mockDispatches){
-constresponseData=getResponseData(typeofdata==='function' ? data(opts) : data)
+// fetch's HeadersList is a 1D string array
+constoptsHeaders=Array.isArray(opts.headers)
+ ? buildHeadersFromArray(opts.headers)
+ : opts.headers
+constresponseData=getResponseData(
+typeofdata==='function' ? data({ ...opts,headers: optsHeaders}) : data
+)
 constresponseHeaders=generateKeyValues(headers)
 constresponseTrailers=generateKeyValues(trailers)