Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Add copy buttons to all
 blocks\n(function() {\n function addCopyButtons() {\n document.querySelectorAll('pre code').forEach(function(codeBlock) {\n if (codeBlock.parentElement.hasAttribute('data-copy-added')) return;\n codeBlock.parentElement.setAttribute('data-copy-added', 'true');\n \n var btn = document.createElement('button');\n btn.textContent = 'Copy';\n btn.style.cssText = 'position:absolute;top:4px;right:4px;padding:2px 8px;font-size:11px;background:#4ecdc4;border:none;border-radius:4px;color:#1a1a2e;cursor:pointer;opacity:0.7;transition:opacity 0.2s;';\n btn.onmouseover = function() { this.style.opacity = '1'; };\n btn.onmouseout = function() { this.style.opacity = '0.7'; };\n btn.onclick = function() {\n navigator.clipboard.writeText(codeBlock.textContent).then(function() {\n btn.textContent = 'Copied!';\n setTimeout(function() { btn.textContent = 'Copy'; }, 1500);\n });\n };\n codeBlock.parentElement.style.position = 'relative';\n codeBlock.parentElement.appendChild(btn);\n });\n }\n \n addCopyButtons();\n \n // Re-run on dynamic content\n var observer = new MutationObserver(addCopyButtons);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Add Copy Buttons to Code Blocks");
}
} catch(__e) { console.warn('[Userscript:Add Copy Buttons to Code Blocks]', __e); }
})();
(function(){
try {
var __m = "github.com";
var __re = new RegExp('^' + "github\\.com" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Force GitHub README to respect dark mode\n(function() {\n var style = document.createElement('style');\n style.textContent = '\n .markdown-body {\n color-scheme: dark light;\n }\n .markdown-body pre { background: #161b22 !important; }\n .markdown-body code { background: rgba(110, 118, 129, 0.4) !important; }\n .markdown-body table th, .markdown-body table td { border-color: #30363d !important; }\n .markdown-body img { background: #0d1117; }\n .markdown-body blockquote { border-left-color: #8b949e; }\n .markdown-body hr { border-color: #30363d; }\n ';\n document.head.appendChild(style);\n})();", "GitHub Dark Mode README Fix"); } } catch(__e) { console.warn('[Userscript:GitHub Dark Mode README Fix]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Highlight search terms from Google/DuckDuckGo/Bing referrer\n(function() {\n var ref = document.referrer;\n var terms = [];\n \n if (ref.includes('google.com') || ref.includes('duckduckgo.com') || ref.includes('bing.com')) {\n var url = new URL(ref);\n var q = url.searchParams.get('q') || url.searchParams.get('p');\n if (q) {\n terms = q.split(/\\s+/).filter(function(t) { return t.length > 2; });\n }\n }\n \n if (terms.length === 0) return;\n \n var style = document.createElement('style');\n style.textContent = '.userscript-highlight { background: #fbbf24; color: #1a1a2e; padding: 1px 3px; border-radius: 2px; }';\n document.head.appendChild(style);\n \n function highlight(node) {\n if (node.nodeType === 3) { // text node\n var text = node.textContent;\n var found = false;\n terms.forEach(function(term) {\n var regex = new RegExp('(' + term.replace(/[.*+?^${}()|[\\]\\\\]/g, '\\\\') + ')', 'gi');\n if (regex.test(text)) {\n found = true;\n var frag = document.createDocumentFragment();\n var parts = text.split(regex);\n parts.forEach(function(part, i) {\n if (i % 2 === 0) {\n frag.appendChild(document.createTextNode(part));\n } else {\n var span = document.createElement('span');\n span.className = 'userscript-highlight';\n span.textContent = part;\n frag.appendChild(span);\n }\n });\n node.parentNode.replaceChild(frag, node);\n }\n });\n } else if (node.nodeType === 1 && node.childNodes) { // element\n var skipTags = ['SCRIPT', 'STYLE', 'NOSCRIPT', 'TEXTAREA', 'INPUT', 'SELECT'];\n if (!skipTags.includes(node.tagName)) {\n Array.from(node.childNodes).forEach(highlight);\n }\n }\n }\n \n highlight(document.body);\n \n // Re-highlight on dynamic content\n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1 || node.nodeType === 3) highlight(node);\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Highlight Search Terms"); } } catch(__e) { console.warn('[Userscript:Highlight Search Terms]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Strip utm_, fbclid, gclid, etc. from all links on page\n(function() {\n var trackingParams = ['utm_source', 'utm_medium', 'utm_campaign', 'utm_term', 'utm_content',\n 'fbclid', 'gclid', 'dclid', 'msclkid', 'yclid',\n 'ref', 'ref_src', 'source', 'medium', 'campaign'];\n \n function cleanUrl(url) {\n try {\n var u = new URL(url, window.location.origin);\n var changed = false;\n trackingParams.forEach(function(p) {\n if (u.searchParams.has(p)) {\n u.searchParams.delete(p);\n changed = true;\n }\n });\n return changed ? u.toString() : url;\n } catch (e) {\n return url;\n }\n }\n \n function cleanLinks() {\n document.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n \n cleanLinks();\n \n var observer = new MutationObserver(function(mutations) {\n mutations.forEach(function(m) {\n m.addedNodes.forEach(function(node) {\n if (node.nodeType === 1) {\n if (node.tagName === 'A') cleanLinks();\n node.querySelectorAll('a[href]').forEach(function(a) {\n var clean = cleanUrl(a.href);\n if (clean !== a.href) a.href = clean;\n });\n }\n });\n });\n });\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "Remove Tracking Parameters from Links"); } } catch(__e) { console.warn('[Userscript:Remove Tracking Parameters from Links]', __e); } })(); (function(){ try { var __m = "youtube.com"; var __re = new RegExp('^' + "youtube\\.com" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Auto-enable theater mode on YouTube\n(function() {\n function tryTheater() {\n var btn = document.querySelector('button[aria-label=\"Theater mode\"], ytd-player #player button[title=\"Theater mode\"]');\n if (btn && !btn.classList.contains('activated')) {\n btn.click();\n }\n }\n \n // Try immediately\n tryTheater();\n \n // Try after navigation (SPA)\n var lastUrl = location.href;\n setInterval(function() {\n if (location.href !== lastUrl) {\n lastUrl = location.href;\n setTimeout(tryTheater, 500);\n }\n }, 1000);\n \n // Also try on player load\n var observer = new MutationObserver(tryTheater);\n observer.observe(document.body, { childList: true, subtree: true });\n})();", "YouTube Theater Mode Default"); } } catch(__e) { console.warn('[Userscript:YouTube Theater Mode Default]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Remove or un-stick sticky/fixed headers that block content\n(function() {\n function unstick() {\n document.querySelectorAll('header, nav, [role=\"banner\"], .header, .navbar, .sticky, .fixed-top, [style*=\"position: fixed\"], [style*=\"position:sticky\"]').forEach(function(el) {\n if (el.style.position === 'fixed' || el.style.position === 'sticky' || \n getComputedStyle(el).position === 'fixed' || getComputedStyle(el).position === 'sticky') {\n el.style.position = 'static';\n el.style.top = 'auto';\n el.style.zIndex = 'auto';\n }\n });\n }\n \n unstick();\n \n var observer = new MutationObserver(unstick);\n observer.observe(document.body, { childList: true, subtree: true, attributes: true, attributeFilter: ['style', 'class'] });\n})();", "Kill Sticky Headers"); } } catch(__e) { console.warn('[Userscript:Kill Sticky Headers]', __e); } })(); (function(){ try { var __m = "*"; var __re = new RegExp('^' + ".*" + '
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)
, 'i'); if (__m === '*' || __re.test(location.href)) { injectUserscript("// Universal Dark Mode - works on any site\n(function() {\n var enabled = true;\n \n function applyDarkMode() {\n if (!enabled) return;\n \n // Create style element if it doesn't exist\n var style = document.getElementById('universal-dark-mode-style');\n if (!style) {\n style = document.createElement('style');\n style.id = 'universal-dark-mode-style';\n document.head.appendChild(style);\n }\n \n // Dark mode CSS - inverts colors but preserves images/video\n style.textContent = '\n /* Invert everything except media */\n html {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #1a1a2e !important;\n }\n \n /* Restore images, videos, iframes, canvas */\n img, video, iframe, canvas, svg, picture, [style*=\"background-image\"] {\n filter: invert(1) hue-rotate(180deg) !important;\n }\n \n /* Preserve specific elements that should not be inverted */\n .no-dark-mode, .no-dark-mode *,\n [data-theme=\"light\"], [data-theme=\"light\"],\n .ace_editor, .ace_editor *,\n .CodeMirror, .CodeMirror *,\n .monaco-editor, .monaco-editor *,\n .markdown-body pre, .markdown-body pre *,\n .highlight, .highlight *,\n pre code, pre code * {\n filter: none !important;\n }\n \n /* Fix common UI elements */\n .modal, .popup, .dropdown-menu, .tooltip, .popover {\n filter: invert(1) hue-rotate(180deg) !important;\n background: #2d2d44 !important;\n border-color: #444 !important;\n }\n \n /* Scrollbars */\n ::-webkit-scrollbar { background: #1a1a2e !important; }\n ::-webkit-scrollbar-thumb { background: #444 !important; }\n ::-webkit-scrollbar-thumb:hover { background: #555 !important; }\n \n /* Selection */\n ::selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ::-moz-selection { background: #4ecdc4 !important; color: #1a1a2e !important; }\n ';\n }\n \n function removeDarkMode() {\n var style = document.getElementById('universal-dark-mode-style');\n if (style) style.remove();\n }\n \n // Toggle with Alt+Shift+D\n document.addEventListener('keydown', function(e) {\n if (e.altKey && e.shiftKey && e.key === 'D') {\n e.preventDefault();\n enabled = !enabled;\n if (enabled) {\n applyDarkMode();\n console.log('[Universal Dark Mode] Enabled');\n } else {\n removeDarkMode();\n console.log('[Universal Dark Mode] Disabled');\n }\n }\n });\n \n // Apply on load\n applyDarkMode();\n \n // Re-apply on dynamic content\n var observer = new MutationObserver(function(mutations) {\n if (enabled && !document.getElementById('universal-dark-mode-style')) {\n applyDarkMode();\n }\n });\n observer.observe(document.head, { childList: true });\n \n console.log('[Universal Dark Mode] Loaded - Press Alt+Shift+D to toggle');\n})();", "Universal Dark Mode"); } } catch(__e) { console.warn('[Userscript:Universal Dark Mode]', __e); } })(); })();
Skip to content

Commit d29cc09

Browse files
pipobscureaduh95
authored andcommitted
zlib: let a ZipFile read finish before close()
An entry read runs on a file descriptor shared with its ZipFile, but reads did not take part in close()'s lifecycle: close() marked the handle closed and released the fd while a read was still in flight, so the read landed on a closed - or worse, an OS-reused - descriptor (surfacing as EBADF, or a cross-file read once the number was reclaimed), despite the class comment promising otherwise. Track in-flight reads on the shared handle. close() now marks the handle closing (rejecting new reads at once), waits for the in-flight reads to finish on the still-open fd, and only then closes it; closeSync(), which cannot wait, refuses while an asynchronous read is outstanding. Signed-off-by: Philipp Dunkel <pip@pipobscure.com> PR-URL: #65016 Reviewed-By: Matteo Collina <matteo.collina@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 00b687b commit d29cc09

2 files changed

Lines changed: 89 additions & 30 deletions

File tree

β€Žlib/internal/zip/entry.jsβ€Ž

Lines changed: 62 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -175,6 +175,17 @@ function createEntryMeta(filename, options) {
175175
};
176176
}
177177

178+
// Release one in-flight read on a shared ZipFile descriptor handle. When the
179+
// last read settles, wake a close() that is waiting to release the fd (see
180+
// ZipFile.close() in file.js), so a read never lands on a closed/reused fd.
181+
functionendHandleRead(handle){
182+
if(--handle.reads===0&&handle.drain!==null){
183+
constdrain=handle.drain;
184+
handle.drain=null;
185+
drain();
186+
}
187+
}
188+
178189
/**
179190
* A single file or directory inside a ZIP archive: reading, writing, and
180191
* (de)serializing one archive member.
@@ -490,17 +501,30 @@ class ZipEntry {
490501
// The entry's raw compressed bytes as a bounded-memory chunk stream, read
491502
// straight from disk (file-backed entries only). Nothing is retained.
492503
async*#rawChunks(){
493-
this.#liveDescriptor();
494-
letpos=awaitthis.#resolveContentOffset();
495-
letremaining=this.compressedSize;
496-
while(remaining>0){
497-
consttake=MathMin(READ_CHUNK_SIZE,remaining);
498-
constchunk=Buffer.allocUnsafe(take);
499-
// Re-check per chunk: the ZipFile may be closed mid-stream.
500-
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
501-
pos+=take;
502-
remaining-=take;
503-
yieldchunk;
504+
// Count the whole stream as one in-flight read so a concurrent close()
505+
// waits for it (the finally runs when the consumer stops iterating); a
506+
// stream begun after close() was requested is rejected up front.
507+
consthandle=this.#fd;
508+
if(handle.closing){
509+
thrownewERR_INVALID_STATE(
510+
'cannot read a ZipEntry after its backing ZipFile has been closed');
511+
}
512+
handle.reads++;
513+
try{
514+
this.#liveDescriptor();
515+
letpos=awaitthis.#resolveContentOffset();
516+
letremaining=this.compressedSize;
517+
while(remaining>0){
518+
consttake=MathMin(READ_CHUNK_SIZE,remaining);
519+
constchunk=Buffer.allocUnsafe(take);
520+
// Re-check per chunk: the ZipFile may be closed mid-stream.
521+
awaitreadFdFully(this.#liveDescriptor(),chunk,pos);
522+
pos+=take;
523+
remaining-=take;
524+
yieldchunk;
525+
}
526+
}finally{
527+
endHandleRead(handle);
504528
}
505529
}
506530
// Sync counterpart of #rawChunks().
@@ -533,18 +557,33 @@ class ZipEntry {
533557
`entry ${JSONStringify(this.name)} declares ${declared} bytes, `+
534558
`exceeding the ${maxSize} byte limit`);
535559
}
536-
constcompressed=awaitthis.#compressedBytes();
537-
constdata=awaitdecodeMemberAsync(compressed,{
538-
name: this.name,
539-
flags: this.flags,
540-
method: this.method,
541-
crc32: this.crc32,
542-
uncompressedSize: declared,
543-
},{verify: options?.verify, maxSize });
544-
// `data === compressed` only on the store path; copy the in-memory case
545-
// (the entry's retained buffer, see #compressedBytes()) so the result is
546-
// caller-owned on every path.
547-
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
560+
// Count this read on the shared handle so a concurrent close() waits for it
561+
// rather than releasing the fd mid-read; a read begun after close() was
562+
// requested is rejected up front (in-memory entries have no fd).
563+
consthandle=this.#fd;
564+
if(handle!==null){
565+
if(handle.closing){
566+
thrownewERR_INVALID_STATE(
567+
'cannot read a ZipEntry after its backing ZipFile has been closed');
568+
}
569+
handle.reads++;
570+
}
571+
try{
572+
constcompressed=awaitthis.#compressedBytes();
573+
constdata=awaitdecodeMemberAsync(compressed,{
574+
name: this.name,
575+
flags: this.flags,
576+
method: this.method,
577+
crc32: this.crc32,
578+
uncompressedSize: declared,
579+
},{verify: options?.verify, maxSize });
580+
// `data === compressed` only on the store path; copy the in-memory case
581+
// (the entry's retained buffer, see #compressedBytes()) so the result is
582+
// caller-owned on every path.
583+
returndata===compressed&&this.#fd ===null ? Buffer.from(data) : data;
584+
}finally{
585+
if(handle!==null)endHandleRead(handle);
586+
}
548587
}
549588

550589
/**

β€Žlib/internal/zip/file.jsβ€Ž

Lines changed: 27 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -19,6 +19,7 @@ const {
1919
MapPrototypeKeys,
2020
MapPrototypeSet,
2121
MathMin,
22+
Promise,
2223
PromisePrototypeThen,
2324
PromiseResolve,
2425
SymbolAsyncDispose,
@@ -218,12 +219,14 @@ function checkMemberOverlap(members, centralDirectoryOffset) {
218219
* corrupt the archive.
219220
*/
220221
classZipFile{
221-
// Shared descriptor handle ({ fd, closed }) handed to every ZipEntry this
222-
// archive produces, so close() can invalidate them all at once. `#closing`
223-
// is set synchronously the moment close()/closeSync() is called, gating any
224-
// further public call; `handle.closed` is set once the fd is actually gone,
225-
// gating reads through already-handed-out entries. Neither read ever falls
226-
// through to a bare (possibly OS-reused) descriptor number.
222+
// Shared descriptor handle ({ fd, closed, reads, drain }) handed to every
223+
// ZipEntry this archive produces, so close() can invalidate them all at once.
224+
// `#closing` is set synchronously the moment close()/closeSync() is called,
225+
// gating any further public call; `handle.closed` then stops new reads, and
226+
// `handle.reads` counts in-flight reads through already-handed-out entries so
227+
// close() can wait for them to finish before releasing the fd. Neither a new
228+
// nor an in-flight read ever falls through to a closed (possibly OS-reused)
229+
// descriptor number.
227230
#handle;
228231
#closing =false;
229232
#closePromise =null;
@@ -240,7 +243,7 @@ class ZipFile {
240243
* @private
241244
*/
242245
constructor(fd,centralHeaders,prefix,centralDirectoryOffset,comment,writable){
243-
this.#handle ={ fd,closed: false};
246+
this.#handle ={ fd,closed: false,closing: false,reads: 0,drain: null};
244247
this.#writable =writable;
245248
this.#comment =comment;
246249
this.#centralDirectoryOffset =centralDirectoryOffset;
@@ -655,7 +658,16 @@ class ZipFile {
655658
close(){
656659
if(this.#closing)returnthis.#closePromise ??PromiseResolve();
657660
this.#closing =true;
661+
// Block *new* reads immediately; reads already in flight keep the still-open
662+
// fd until they finish (handle.closed, set below, is what stops mid-read).
663+
this.#handle.closing=true;
658664
this.#closePromise =this.#enqueue(async()=>{
665+
// Let reads already in flight through handed-out entries finish on the
666+
// open fd before releasing it; endHandleRead() (entry.js) resolves this
667+
// once the last one settles.
668+
if(this.#handle.reads>0){
669+
awaitnewPromise((resolve)=>{this.#handle.drain=resolve;});
670+
}
659671
this.#handle.closed=true;
660672
MapPrototypeClear(this.#entries);
661673
awaitfsCloseAsync(this.#handle.fd);
@@ -669,7 +681,15 @@ class ZipFile {
669681
closeSync(){
670682
if(this.#closing)return;
671683
this.#assertNotBusy();
684+
// A synchronous close cannot wait for an async read the way close() does,
685+
// so refuse rather than pull the fd out from under one still in flight.
686+
if(this.#handle.reads>0){
687+
thrownewERR_INVALID_STATE(
688+
'cannot synchronously close a ZipFile while an asynchronous read is '+
689+
'still in flight');
690+
}
672691
this.#closing =true;
692+
this.#handle.closing=true;
673693
this.#handle.closed=true;
674694
MapPrototypeClear(this.#entries);
675695
fs.closeSync(this.#handle.fd);

0 commit comments

Comments
Β (0)