test,benchmark,doc: enable dot-notation rule

This enables the eslint dot-notation rule for all code instead of
only in /lib.
PR-URL: #18749
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>

Author: BridgeAR

.eslintrc.yaml

@@ -44,6 +44,7 @@ rules:
 # http://eslint.org/docs/rules/#best-practices
 accessor-pairs: error
 dot-location: [error, property]
+dot-notation: error
 eqeqeq: [error, smart]
 no-fallthrough: error
 no-global-assign: error

benchmark/misc/object-property-bench.js

@@ -1,5 +1,7 @@
 'use strict';
 
+/* eslint-disable dot-notation */
+
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{

doc/api/http2.md

@@ -1236,7 +1236,7 @@ const server = http2.createServer();
 server.on('stream', (stream) => {
 stream.respond({ ':status':200 }, {
 getTrailers(trailers) {
- trailers['ABC']='some value to send';
+trailers.ABC='some value to send';
  }
  });
 stream.end('some data');
@@ -1326,7 +1326,7 @@ server.on('stream', (stream) => {
  };
 stream.respondWithFD(fd, headers, {
 getTrailers(trailers) {
- trailers['ABC']='some value to send';
+trailers.ABC='some value to send';
  }
  });
 
@@ -1435,7 +1435,7 @@ const http2 = require('http2');
 constserver=http2.createServer();
 server.on('stream', (stream) => {
 functiongetTrailers(trailers) {
- trailers['ABC']='some value to send';
+trailers.ABC='some value to send';
  }
 stream.respondWithFile('/some/file',
  { 'content-type':'text/plain' },

lib/.eslintrc.yaml

@@ -1,6 +1,4 @@
 rules:
-dot-notation: error
-
 # Custom rules in tools/eslint-rules
 require-buffer: error
 buffer-constructor: error

test/addons-napi/test_symbol/test1.js

@@ -8,11 +8,10 @@ const test_symbol = require(`./build/${common.buildType}/test_symbol`);
 constsym=test_symbol.New('test');
 assert.strictEqual(sym.toString(),'Symbol(test)');
 
-
 constmyObj={};
 constfooSym=test_symbol.New('foo');
 constotherSym=test_symbol.New('bar');
-myObj['foo']='bar';
+myObj.foo='bar';
 myObj[fooSym]='baz';
 myObj[otherSym]='bing';
 assert.strictEqual(myObj.foo,'bar');

test/addons-napi/test_symbol/test2.js

@@ -7,7 +7,7 @@ const test_symbol = require(`./build/${common.buildType}/test_symbol`);
 
 constfooSym=test_symbol.New('foo');
 constmyObj={};
-myObj['foo']='bar';
+myObj.foo='bar';
 myObj[fooSym]='baz';
 Object.keys(myObj);// -> [ 'foo' ]
 Object.getOwnPropertyNames(myObj);// -> [ 'foo' ]

test/common/index.js

@@ -512,7 +512,7 @@ exports.canCreateSymLink = function() {
 // whoami.exe needs to be the one from System32
 // If unix tools are in the path, they can shadow the one we want,
 // so use the full path while executing whoami
-constwhoamiPath=path.join(process.env['SystemRoot'],
+constwhoamiPath=path.join(process.env.SystemRoot,
 'System32','whoami.exe');
 
 leterr=false;

test/common/inspector-helper.js

@@ -167,9 +167,7 @@ class InspectorSession {
 reject(message.error);
 }else{
 if(message.method==='Debugger.scriptParsed'){
-constscript=message['params'];
-constscriptId=script['scriptId'];
-consturl=script['url'];
+const{ scriptId, url }=message.params;
 this._scriptsIdsByUrl.set(scriptId,url);
 if(url===_MAINSCRIPT)
 this.mainScriptId=scriptId;
@@ -188,12 +186,12 @@ class InspectorSession {
 
 _sendMessage(message){
 constmsg=JSON.parse(JSON.stringify(message));// Clone!
-msg['id']=this._nextId++;
+msg.id=this._nextId++;
 if(DEBUG)
 console.log('[sent]',JSON.stringify(msg));
 
 constresponsePromise=newPromise((resolve,reject)=>{
-this._commandResponsePromises.set(msg['id'],{ resolve, reject });
+this._commandResponsePromises.set(msg.id,{ resolve, reject });
 });
 
 returnnewPromise(
@@ -238,12 +236,15 @@ class InspectorSession {
 returnnotification;
 }
 
-_isBreakOnLineNotification(message,line,url){
-if('Debugger.paused'===message['method']){
-constcallFrame=message['params']['callFrames'][0];
-constlocation=callFrame['location'];
-assert.strictEqual(url,this._scriptsIdsByUrl.get(location['scriptId']));
-assert.strictEqual(line,location['lineNumber']);
+_isBreakOnLineNotification(message,line,expectedScriptPath){
+if('Debugger.paused'===message.method){
+constcallFrame=message.params.callFrames[0];
+constlocation=callFrame.location;
+constscriptPath=this._scriptsIdsByUrl.get(location.scriptId);
+assert.strictEqual(scriptPath.toString(),
+expectedScriptPath.toString(),
+`${scriptPath} !== ${expectedScriptPath}`);
+assert.strictEqual(line,location.lineNumber);
 returntrue;
 }
 }
@@ -259,12 +260,12 @@ class InspectorSession {
 _matchesConsoleOutputNotification(notification,type,values){
 if(!Array.isArray(values))
 values=[values];
-if('Runtime.consoleAPICalled'===notification['method']){
-constparams=notification['params'];
-if(params['type']===type){
+if('Runtime.consoleAPICalled'===notification.method){
+constparams=notification.params;
+if(params.type===type){
 leti=0;
-for(constvalueofparams['args']){
-if(value['value']!==values[i++])
+for(constvalueofparams.args){
+if(value.value!==values[i++])
 returnfalse;
 }
 returni===values.length;
@@ -389,7 +390,7 @@ class NodeInstance {
 asyncconnectInspectorSession(){
 console.log('[test]','Connecting to a child Node process');
 constresponse=awaitthis.httpGet(null,'/json/list');
-consturl=response[0]['webSocketDebuggerUrl'];
+consturl=response[0].webSocketDebuggerUrl;
 returnthis.wsHandshake(url);
 }
 

test/parallel/test-cluster-fork-env.js

@@ -31,8 +31,8 @@ const cluster = require('cluster');
 
 if(cluster.isWorker){
 constresult=cluster.worker.send({
-prop: process.env['cluster_test_prop'],
-overwrite: process.env['cluster_test_overwrite']
+prop: process.env.cluster_test_prop,
+overwrite: process.env.cluster_test_overwrite
 });
 
 assert.strictEqual(result,true);
@@ -45,7 +45,7 @@ if (cluster.isWorker) {
 
 // To check that the cluster extend on the process.env we will overwrite a
 // property
-process.env['cluster_test_overwrite']='old';
+process.env.cluster_test_overwrite='old';
 
 // Fork worker
 constworker=cluster.fork({

test/parallel/test-crypto-hmac.js

@@ -71,13 +71,13 @@ const wikipedia = [
 ];
 
 for(leti=0,l=wikipedia.length;i<l;i++){
-for(consthashinwikipedia[i]['hmac']){
+for(consthashinwikipedia[i].hmac){
 // FIPS does not support MD5.
 if(common.hasFipsCrypto&&hash==='md5')
 continue;
-constexpected=wikipedia[i]['hmac'][hash];
-constactual=crypto.createHmac(hash,wikipedia[i]['key'])
-.update(wikipedia[i]['data'])
+constexpected=wikipedia[i].hmac[hash];
+constactual=crypto.createHmac(hash,wikipedia[i].key)
+.update(wikipedia[i].data)
 .digest('hex');
 assert.strictEqual(
 actual,
@@ -236,18 +236,18 @@ const rfc4231 = [
 ];
 
 for(leti=0,l=rfc4231.length;i<l;i++){
-for(consthashinrfc4231[i]['hmac']){
+for(consthashinrfc4231[i].hmac){
 conststr=crypto.createHmac(hash,rfc4231[i].key);
 str.end(rfc4231[i].data);
 letstrRes=str.read().toString('hex');
-letactual=crypto.createHmac(hash,rfc4231[i]['key'])
-.update(rfc4231[i]['data'])
+letactual=crypto.createHmac(hash,rfc4231[i].key)
+.update(rfc4231[i].data)
 .digest('hex');
-if(rfc4231[i]['truncate']){
+if(rfc4231[i].truncate){
 actual=actual.substr(0,32);// first 128 bits == 32 hex chars
 strRes=strRes.substr(0,32);
 }
-constexpected=rfc4231[i]['hmac'][hash];
+constexpected=rfc4231[i].hmac[hash];
 assert.strictEqual(
 actual,
 expected,
@@ -368,10 +368,10 @@ const rfc2202_sha1 = [
 
 if(!common.hasFipsCrypto){
 for(leti=0,l=rfc2202_md5.length;i<l;i++){
-constactual=crypto.createHmac('md5',rfc2202_md5[i]['key'])
-.update(rfc2202_md5[i]['data'])
+constactual=crypto.createHmac('md5',rfc2202_md5[i].key)
+.update(rfc2202_md5[i].data)
 .digest('hex');
-constexpected=rfc2202_md5[i]['hmac'];
+constexpected=rfc2202_md5[i].hmac;
 assert.strictEqual(
 actual,
 expected,
@@ -380,10 +380,10 @@ if (!common.hasFipsCrypto) {
 }
 }
 for(leti=0,l=rfc2202_sha1.length;i<l;i++){
-constactual=crypto.createHmac('sha1',rfc2202_sha1[i]['key'])
-.update(rfc2202_sha1[i]['data'])
+constactual=crypto.createHmac('sha1',rfc2202_sha1[i].key)
+.update(rfc2202_sha1[i].data)
 .digest('hex');
-constexpected=rfc2202_sha1[i]['hmac'];
+constexpected=rfc2202_sha1[i].hmac;
 assert.strictEqual(
 actual,
 expected,