lib: remove some useless assignments

devsnek · BethGriggs · commit d5d8670783ac · 2019-02-12T17:58:05.000Z
PR-URL: #23199 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
diff --git a/lib/events.js b/lib/events.js
@@ -224,7 +224,7 @@ function _addListener(target, type, listener, prepend) {
 
 if (existing === undefined) {
 // Optimize the case of one listener. Don't need the extra array object.
- existing = events[type] = listener;
+ events[type] = listener;
 ++target._eventsCount;
 } else {
 if (typeof existing === 'function') {
diff --git a/lib/internal/readline.js b/lib/internal/readline.js
@@ -258,7 +258,7 @@ function* emitKeys(stream) {
 s += (ch = yield);
 
 if (ch >= '0' && ch <= '9') {
- s += (ch = yield);
+ s += yield;
 }
 }
 
diff --git a/lib/net.js b/lib/net.js
@@ -1071,10 +1071,6 @@ function afterConnect(status, handle, req, readable, writable) {
 return;
 }
 
- // Update handle if it was wrapped
- // TODO(indutny): assert that the handle is actually an ancestor of old one
- handle = self._handle;
-
 debug('afterConnect');
 
 assert(self.connecting);

-Original file line number
+Diff line change
 if(existing===undefined){
 // Optimize the case of one listener. Don't need the extra array object.
 -existing=events[type]=listener;
 +events[type]=listener;
 ++target._eventsCount;
 }else{
 if(typeofexisting==='function'){
Original file line number	Diff line number	Diff line change
`@@ -258,7 +258,7 @@ function* emitKeys(stream) {`
`258`	`258`	`s+=(ch=yield);`
`259`	`259`
`260`	`260`	`if(ch>='0'&&ch<='9'){`
`261`		`-s+=(ch=yield);`
	`261`	`+s+=yield;`
`262`	`262`	`}`
`263`	`263`	`}`
`264`	`264`
Original file line number	Diff line number	Diff line change
`@@ -1071,10 +1071,6 @@ function afterConnect(status, handle, req, readable, writable) {`
`1071`	`1071`	`return;`
`1072`	`1072`	`}`
`1073`	`1073`
`1074`		`-// Update handle if it was wrapped`
`1075`		`-// TODO(indutny): assert that the handle is actually an ancestor of old one`
`1076`		`-handle=self._handle;`
`1077`		`-`
`1078`	`1074`	`debug('afterConnect');`
`1079`	`1075`
`1080`	`1076`	`assert(self.connecting);`