http2: use correct connect event for TLS Socket

jasnell · MylesBorins · commit d60771844874 · 2017-12-07T13:24:46.000-05:00
PR-URL: #17328 Fixes: #15303 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Sebastiaan Deckers <sebdeckers83@gmail.com>
diff --git a/lib/internal/http2/core.js b/lib/internal/http2/core.js
@@ -773,7 +773,9 @@ class Http2Session extends EventEmitter {
 const setupFn = setupHandle(this, socket, type, options);
 if (socket.connecting) {
 this[kState].connecting = true;
- socket.once('connect', setupFn);
+ const connectEvent =
+ socket instanceof tls.TLSSocket ? 'secureConnect' : 'connect';
+ socket.once(connectEvent, setupFn);
 } else {
 setupFn();
 }

-Original file line number
+Diff line change
 constsetupFn=setupHandle(this,socket,type,options);
 if(socket.connecting){
 this[kState].connecting=true;
 -socket.once('connect',setupFn);
 +constconnectEvent=
 +socketinstanceoftls.TLSSocket ? 'secureConnect' : 'connect';
 +socket.once(connectEvent,setupFn);
 }else{
 setupFn();
+}