timer,domain: maintain order of timer callbacks

PR-URL: #10522Fixes: #1271
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>

Author: jBarz

lib/timers.js

@@ -156,12 +156,19 @@ function TimersList(msecs, unrefed) {
 this._timer=newTimerWrap();
 this._unrefed=unrefed;
 this.msecs=msecs;
+this.nextTick=false;
 }
 
 functionlistOnTimeout(){
 varlist=this._list;
 varmsecs=list.msecs;
 
+if(list.nextTick){
+list.nextTick=false;
+process.nextTick(listOnTimeoutNT,list);
+return;
+}
+
 debug('timeout callback %d',msecs);
 
 varnow=TimerWrap.now();
@@ -239,6 +246,14 @@ function tryOnTimeout(timer, list) {
 }finally{
 if(!threw)return;
 
+// Postpone all later list events to next tick. We need to do this
+// so that the events are called in the order they were created.
+constlists=list._unrefed===true ? unrefedLists : refedLists;
+for(varkeyinlists){
+if(key>list.msecs){
+lists[key].nextTick=true;
+}
+}
 // We need to continue processing after domain error handling
 // is complete, but not by using whatever domain was left over
 // when the timeout threw its exception.

test/parallel/test-domain-timers-uncaught-exception.js

@@ -0,0 +1,25 @@
+'use strict';
+constcommon=require('../common');
+
+// This test ensures that the timer callbacks are called in the order in which
+// they were created in the event of an unhandled exception in the domain.
+
+constdomain=require('domain').create();
+constassert=require('assert');
+
+letfirst=false;
+
+domain.run(function(){
+setTimeout(()=>{thrownewError('FAIL');},1);
+setTimeout(()=>{first=true;},1);
+setTimeout(()=>{assert.strictEqual(first,true);},2);
+
+// Ensure that 2 ms have really passed
+leti=1e6;
+while(i--);
+});
+
+domain.once('error',common.mustCall((err)=>{
+assert(err);
+assert.strictEqual(err.message,'FAIL');
+}));