timers: fix binding fast call signatures

PR-URL: #59600
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: Renegade334

src/timers.cc

@@ -53,9 +53,8 @@ void BindingData::SlowScheduleTimer(const FunctionCallbackInfo<Value>& args) {
  }
 }
 
-voidBindingData::FastScheduleTimer(Local<Object> unused,
- Local<Object> receiver,
-int64_t duration) {
+voidBindingData::FastScheduleTimer(Local<Object> receiver, int64_t duration) {
+TRACK_V8_FAST_API_CALL("timers.scheduleTimer");
 ScheduleTimerImpl(FromJSObject<BindingData>(receiver), duration);
 }
 
@@ -69,9 +68,8 @@ void BindingData::SlowToggleTimerRef(
  args[0]->IsTrue());
 }
 
-voidBindingData::FastToggleTimerRef(Local<Object> unused,
- Local<Object> receiver,
-bool ref) {
+voidBindingData::FastToggleTimerRef(Local<Object> receiver, bool ref) {
+TRACK_V8_FAST_API_CALL("timers.toggleTimerRef");
 ToggleTimerRefImpl(FromJSObject<BindingData>(receiver), ref);
 }
 
@@ -85,9 +83,8 @@ void BindingData::SlowToggleImmediateRef(
  args[0]->IsTrue());
 }
 
-voidBindingData::FastToggleImmediateRef(Local<Object> unused,
- Local<Object> receiver,
-bool ref) {
+voidBindingData::FastToggleImmediateRef(Local<Object> receiver, bool ref) {
+TRACK_V8_FAST_API_CALL("timers.toggleImmediateRef");
 ToggleImmediateRefImpl(FromJSObject<BindingData>(receiver), ref);
 }
 

src/timers.h

@@ -31,23 +31,18 @@ class BindingData : public SnapshotableObject {
 
 staticvoidSlowScheduleTimer(
 const v8::FunctionCallbackInfo<v8::Value>& args);
-staticvoidFastScheduleTimer(v8::Local<v8::Object> unused,
- v8::Local<v8::Object> receiver,
+staticvoidFastScheduleTimer(v8::Local<v8::Object> receiver,
 int64_t duration);
 staticvoidScheduleTimerImpl(BindingData* data, int64_t duration);
 
 staticvoidSlowToggleTimerRef(
 const v8::FunctionCallbackInfo<v8::Value>& args);
-staticvoidFastToggleTimerRef(v8::Local<v8::Object> unused,
- v8::Local<v8::Object> receiver,
-bool ref);
+staticvoidFastToggleTimerRef(v8::Local<v8::Object> receiver, bool ref);
 staticvoidToggleTimerRefImpl(BindingData* data, bool ref);
 
 staticvoidSlowToggleImmediateRef(
 const v8::FunctionCallbackInfo<v8::Value>& args);
-staticvoidFastToggleImmediateRef(v8::Local<v8::Object> unused,
- v8::Local<v8::Object> receiver,
-bool ref);
+staticvoidFastToggleImmediateRef(v8::Local<v8::Object> receiver, bool ref);
 staticvoidToggleImmediateRefImpl(BindingData* data, bool ref);
 
 staticvoidCreatePerIsolateProperties(IsolateData* isolate_data,

test/parallel/test-timers-fast-calls.js

@@ -0,0 +1,28 @@
+// Flags: --allow-natives-syntax --expose-internals --no-warnings
+'use strict';
+
+constcommon=require('../common');
+constassert=require('assert');
+
+const{ internalBinding }=require('internal/test/binding');
+constbinding=internalBinding('timers');
+
+functiontestFastCalls(){
+binding.scheduleTimer(1);
+binding.toggleTimerRef(true);
+binding.toggleTimerRef(false);
+binding.toggleImmediateRef(true);
+binding.toggleImmediateRef(false);
+}
+
+eval('%PrepareFunctionForOptimization(testFastCalls)');
+testFastCalls();
+eval('%OptimizeFunctionOnNextCall(testFastCalls)');
+testFastCalls();
+
+if(common.isDebug){
+const{ getV8FastApiCallCount }=internalBinding('debug');
+assert.strictEqual(getV8FastApiCallCount('timers.scheduleTimer'),1);
+assert.strictEqual(getV8FastApiCallCount('timers.toggleTimerRef'),2);
+assert.strictEqual(getV8FastApiCallCount('timers.toggleImmediateRef'),2);
+}