Skip to content

Commit d7ca223

Browse files
fossamagnabengl
authored andcommitted
test: use mustSucceed instead of mustCall with assert.ifError
PR-URL: #43188 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Zeyu "Alex" Yang <himself65@outlook.com>
1 parent 8f5b457 commit d7ca223

1 file changed

Lines changed: 7 additions & 9 deletions

File tree

‎test/parallel/test-fs-options-immutable.js‎

Lines changed: 7 additions & 9 deletions
Original file line numberDiff line numberDiff line change
@@ -6,19 +6,17 @@ const common = require('../common');
66
//
77
// Refer: https://github.com/nodejs/node/issues/7655
88

9-
constassert=require('assert');
109
constfs=require('fs');
1110
constpath=require('path');
1211

13-
consterrHandler=(e)=>assert.ifError(e);
1412
constoptions=Object.freeze({});
1513
consttmpdir=require('../common/tmpdir');
1614
tmpdir.refresh();
1715

18-
fs.readFile(__filename,options,common.mustCall(errHandler));
16+
fs.readFile(__filename,options,common.mustSucceed());
1917
fs.readFileSync(__filename,options);
2018

21-
fs.readdir(__dirname,options,common.mustCall(errHandler));
19+
fs.readdir(__dirname,options,common.mustSucceed());
2220
fs.readdirSync(__dirname,options);
2321

2422
if(common.canCreateSymLink()){
@@ -28,20 +26,20 @@ if (common.canCreateSymLink()) {
2826
fs.writeFileSync(sourceFile,'');
2927
fs.symlinkSync(sourceFile,linkFile);
3028

31-
fs.readlink(linkFile,options,common.mustCall(errHandler));
29+
fs.readlink(linkFile,options,common.mustSucceed());
3230
fs.readlinkSync(linkFile,options);
3331
}
3432

3533
{
3634
constfileName=path.resolve(tmpdir.path,'writeFile');
3735
fs.writeFileSync(fileName,'ABCD',options);
38-
fs.writeFile(fileName,'ABCD',options,common.mustCall(errHandler));
36+
fs.writeFile(fileName,'ABCD',options,common.mustSucceed());
3937
}
4038

4139
{
4240
constfileName=path.resolve(tmpdir.path,'appendFile');
4341
fs.appendFileSync(fileName,'ABCD',options);
44-
fs.appendFile(fileName,'ABCD',options,common.mustCall(errHandler));
42+
fs.appendFile(fileName,'ABCD',options,common.mustSucceed());
4543
}
4644

4745
if(!common.isIBMi){// IBMi does not support fs.watch()
@@ -56,13 +54,13 @@ if (!common.isIBMi) { // IBMi does not support fs.watch()
5654

5755
{
5856
fs.realpathSync(__filename,options);
59-
fs.realpath(__filename,options,common.mustCall(errHandler));
57+
fs.realpath(__filename,options,common.mustSucceed());
6058
}
6159

6260
{
6361
consttempFileName=path.resolve(tmpdir.path,'mkdtemp-');
6462
fs.mkdtempSync(tempFileName,options);
65-
fs.mkdtemp(tempFileName,options,common.mustCall(errHandler));
63+
fs.mkdtemp(tempFileName,options,common.mustSucceed());
6664
}
6765

6866
{

0 commit comments

Comments
 (0)