test,vm: enable strict mode for vm tests

Some vm tests are not in strict mode because they need to create and use
global variables. By using `global.foo` instead of just `foo`, we can
still enable strict mode.
PR-URL: #6209
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Santiago Gimeno <santiago.gimeno@gmail.com>
Reviewed-By: Minwoo Jung <jmwsoft@gmail.com>

Author: Trott

test/parallel/test-vm-new-script-new-context.js

@@ -1,15 +1,15 @@
-/* eslint-disable strict */
-varcommon=require('../common');
-varassert=require('assert');
-varScript=require('vm').Script;
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+constScript=require('vm').Script;
 
 common.globalCheck=false;
 
 console.error('run a string');
 varscript=newScript('\'passed\';');
 console.error('script created');
-varresult1=script.runInNewContext();
-varresult2=script.runInNewContext();
+constresult1=script.runInNewContext();
+constresult2=script.runInNewContext();
 assert.equal('passed',result1);
 assert.equal('passed',result2);
 
@@ -27,31 +27,31 @@ assert.throws(function() {
 },/notdefined/);
 
 
-hello=5;
+global.hello=5;
 script=newScript('hello = 2');
 script.runInNewContext();
-assert.equal(5,hello);
+assert.equal(5,global.hello);
 
 
 console.error('pass values in and out');
-code='foo = 1;'+
-'bar = 2;'+
-'if (baz !== 3) throw new Error(\'test fail\');';
-foo=2;
-obj={foo: 0,baz: 3};
-script=newScript(code);
+global.code='foo = 1;'+
+'bar = 2;'+
+'if (baz !== 3) throw new Error(\'test fail\');';
+global.foo=2;
+global.obj={foo: 0,baz: 3};
+script=newScript(global.code);
 /* eslint-disable no-unused-vars */
-varbaz=script.runInNewContext(obj);
+varbaz=script.runInNewContext(global.obj);
 /* eslint-enable no-unused-vars */
-assert.equal(1,obj.foo);
-assert.equal(2,obj.bar);
-assert.equal(2,foo);
+assert.equal(1,global.obj.foo);
+assert.equal(2,global.obj.bar);
+assert.equal(2,global.foo);
 
 console.error('call a function by reference');
 script=newScript('f()');
-functionchangeFoo(){foo=100;}
+functionchangeFoo(){global.foo=100;}
 script.runInNewContext({f: changeFoo});
-assert.equal(foo,100);
+assert.equal(global.foo,100);
 
 console.error('modify an object by reference');
 script=newScript('f.a = 2');

test/parallel/test-vm-new-script-this-context.js

@@ -1,13 +1,13 @@
-/* eslint-disable strict */
-varcommon=require('../common');
-varassert=require('assert');
-varScript=require('vm').Script;
+'use strict';
+constcommon=require('../common');
+constassert=require('assert');
+constScript=require('vm').Script;
 
 common.globalCheck=false;
 
 console.error('run a string');
 varscript=newScript('\'passed\';');
-varresult=script.runInThisContext(script);
+constresult=script.runInThisContext(script);
 assert.equal('passed',result);
 
 console.error('thrown error');
@@ -16,26 +16,26 @@ assert.throws(function() {
 script.runInThisContext(script);
 });
 
-hello=5;
+global.hello=5;
 script=newScript('hello = 2');
 script.runInThisContext(script);
-assert.equal(2,hello);
+assert.equal(2,global.hello);
 
 
 console.error('pass values');
-code='foo = 1;'+
-'bar = 2;'+
-'if (typeof baz !== \'undefined\') throw new Error(\'test fail\');';
-foo=2;
-obj={foo: 0,baz: 3};
-script=newScript(code);
+global.code='foo = 1;'+
+'bar = 2;'+
+'if (typeof baz !== "undefined") throw new Error("test fail");';
+global.foo=2;
+global.obj={foo: 0,baz: 3};
+script=newScript(global.code);
 script.runInThisContext(script);
-assert.equal(0,obj.foo);
-assert.equal(2,bar);
-assert.equal(1,foo);
+assert.equal(0,global.obj.foo);
+assert.equal(2,global.bar);
+assert.equal(1,global.foo);
 
 console.error('call a function');
-f=function(){foo=100;};
+global.f=function(){global.foo=100;};
 script=newScript('f()');
 script.runInThisContext(script);
-assert.equal(100,foo);
+assert.equal(100,global.foo);

test/parallel/test-vm-run-in-new-context.js

@@ -1,45 +1,45 @@
-/* eslint-disable strict */
+'use strict';
 // Flags: --expose-gc
 
-varcommon=require('../common');
-varassert=require('assert');
-varvm=require('vm');
+constcommon=require('../common');
+constassert=require('assert');
+constvm=require('vm');
 
 assert.equal(typeofgc,'function','Run this test with --expose-gc');
 
 common.globalCheck=false;
 
 console.error('run a string');
-varresult=vm.runInNewContext('\'passed\';');
+constresult=vm.runInNewContext('\'passed\';');
 assert.equal('passed',result);
 
 console.error('thrown error');
 assert.throws(function(){
 vm.runInNewContext('throw new Error(\'test\');');
 });
 
-hello=5;
+global.hello=5;
 vm.runInNewContext('hello = 2');
-assert.equal(5,hello);
+assert.equal(5,global.hello);
 
 
 console.error('pass values in and out');
-code='foo = 1;'+
-'bar = 2;'+
-'if (baz !== 3) throw new Error(\'test fail\');';
-foo=2;
-obj={foo: 0,baz: 3};
+global.code='foo = 1;'+
+'bar = 2;'+
+'if (baz !== 3) throw new Error(\'test fail\');';
+global.foo=2;
+global.obj={foo: 0,baz: 3};
 /* eslint-disable no-unused-vars */
-varbaz=vm.runInNewContext(code,obj);
+varbaz=vm.runInNewContext(global.code,global.obj);
 /* eslint-enable no-unused-vars */
-assert.equal(1,obj.foo);
-assert.equal(2,obj.bar);
-assert.equal(2,foo);
+assert.equal(1,global.obj.foo);
+assert.equal(2,global.obj.bar);
+assert.equal(2,global.foo);
 
 console.error('call a function by reference');
-functionchangeFoo(){foo=100;}
+functionchangeFoo(){global.foo=100;}
 vm.runInNewContext('f()',{f: changeFoo});
-assert.equal(foo,100);
+assert.equal(global.foo,100);
 
 console.error('modify an object by reference');
 varf={a: 1};