test: deflake test-buffer-large-size-buffer-alloc

lpinca · RafaelGSS · commit d94b18470014 · 2025-06-23T12:11:07.000-03:00
Use the error message as another condition to skip the test when the buffer allocation fails. Refs: 795dd8eb7988ae38553e Refs: e9c6004a2d580008082b PR-URL: #58734 Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: Stefan Stojanovic <stefan.stojanovic@janeasystems.com> Reviewed-By: LiviaMedeiros <livia@cirno.name> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>
diff --git a/test/pummel/test-buffer-large-size-buffer-alloc.js b/test/pummel/test-buffer-large-size-buffer-alloc.js
@@ -7,12 +7,22 @@ common.skipIf32Bits();
 const assert = require('node:assert');
 const size = 2 ** 31;
 
+let largeBuffer;
+
 // Test Buffer.alloc with size larger than integer range
 try {
- assert.throws(() => Buffer.alloc(size).toString('utf8'), { code: 'ERR_STRING_TOO_LONG' });
+ largeBuffer = Buffer.alloc(size);
 } catch (e) {
- if (e.code !== 'ERR_MEMORY_ALLOCATION_FAILED') {
- throw e;
+ if (
+ e.code === 'ERR_MEMORY_ALLOCATION_FAILED' ||
+ /Array buffer allocation failed/.test(e.message)
+ ) {
+ common.skip('insufficient space for Buffer.alloc');
 }
- common.skip('insufficient space for Buffer.alloc');
+
+ throw e;
 }
+
+assert.throws(() => largeBuffer.toString('utf8'), {
+ code: 'ERR_STRING_TOO_LONG',
+});

-Original file line number
+Diff line change
 constassert=require('node:assert');
 constsize=2**31;
 +letlargeBuffer;
++
 // Test Buffer.alloc with size larger than integer range
 try{
 -assert.throws(()=>Buffer.alloc(size).toString('utf8'),{code: 'ERR_STRING_TOO_LONG'});
 +largeBuffer=Buffer.alloc(size);
 }catch(e){
 -if(e.code!=='ERR_MEMORY_ALLOCATION_FAILED'){
 -throwe;
 +if(
 +e.code==='ERR_MEMORY_ALLOCATION_FAILED'||
 +/Arraybufferallocationfailed/.test(e.message)
 +){
 +common.skip('insufficient space for Buffer.alloc');
+}
 -common.skip('insufficient space for Buffer.alloc');
++
 +throwe;
+}
++
 +assert.throws(()=>largeBuffer.toString('utf8'),{
 +code: 'ERR_STRING_TOO_LONG',
 +});