test_runner: require --enable-source-maps for sourcemap coverage

PR-URL: #55359
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>

Author: avivkeller

lib/internal/test_runner/coverage.js

@@ -57,12 +57,19 @@ class CoverageLine {
 }
 
 classTestCoverage{
-constructor(coverageDirectory,originalCoverageDirectory,workingDirectory,excludeGlobs,includeGlobs,thresholds){
+constructor(coverageDirectory,
+originalCoverageDirectory,
+workingDirectory,
+excludeGlobs,
+includeGlobs,
+sourceMaps,
+thresholds){
 this.coverageDirectory=coverageDirectory;
 this.originalCoverageDirectory=originalCoverageDirectory;
 this.workingDirectory=workingDirectory;
 this.excludeGlobs=excludeGlobs;
 this.includeGlobs=includeGlobs;
+this.sourceMaps=sourceMaps;
 this.thresholds=thresholds;
 }
 
@@ -341,7 +348,7 @@ class TestCoverage {
 mapCoverageWithSourceMap(coverage){
 const{ result }=coverage;
 constsourceMapCache=coverage['source-map-cache'];
-if(!sourceMapCache){
+if(!this.sourceMaps||!sourceMapCache){
 returnresult;
 }
 constnewResult=newSafeMap();
@@ -514,6 +521,7 @@ function setupCoverage(options) {
 options.cwd,
 options.coverageExcludeGlobs,
 options.coverageIncludeGlobs,
+options.sourceMaps,
 {
 __proto__: null,
 line: options.lineCoverage,

test/parallel/test-runner-coverage-source-map.js

@@ -19,6 +19,7 @@ function generateReport(report) {
 }
 
 constflags=[
+'--enable-source-maps',
 '--test','--experimental-test-coverage','--test-reporter','tap',
 ];
 
@@ -40,6 +41,28 @@ describe('Coverage with source maps', async () => {
 constspawned=awaitcommon.spawnPromisified(process.execPath,flags,{
 cwd: fixtures.path('test-runner','coverage')
 });
+
+t.assert.strictEqual(spawned.stderr,'');
+t.assert.ok(spawned.stdout.includes(report));
+t.assert.strictEqual(spawned.code,1);
+});
+
+awaitit('should only work with --enable-source-maps',async(t)=>{
+constreport=generateReport([
+'# --------------------------------------------------------------',
+'# file | line % | branch % | funcs % | uncovered lines',
+'# --------------------------------------------------------------',
+'# a.test.mjs | 100.00 | 100.00 | 100.00 | ',
+'# index.test.js | 71.43 | 66.67 | 100.00 | 6-7',
+'# stdin.test.js | 100.00 | 100.00 | 100.00 | ',
+'# --------------------------------------------------------------',
+'# all files | 85.71 | 87.50 | 100.00 | ',
+'# --------------------------------------------------------------',
+]);
+
+constspawned=awaitcommon.spawnPromisified(process.execPath,flags.slice(1),{
+cwd: fixtures.path('test-runner','coverage')
+});
 t.assert.strictEqual(spawned.stderr,'');
 t.assert.ok(spawned.stdout.includes(report));
 t.assert.strictEqual(spawned.code,1);