net: treat ENOTCONN at shutdown as success

addaleax · addaleax · commit da583010540d · 2019-10-25T09:16:47.000+02:00
While it is not entirely clear why this condition is being triggered, it does resolve a reported bug. Fixes: #26315 PR-URL: #29912 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/net.js b/lib/net.js
@@ -39,7 +39,8 @@ const {
 const assert = require('internal/assert');
 const {
 UV_EADDRINUSE,
- UV_EINVAL
+ UV_EINVAL,
+ UV_ENOTCONN
 } = internalBinding('uv');
 
 const { Buffer } = require('buffer');
@@ -403,7 +404,7 @@ Socket.prototype._final = function(cb) {
 req.callback = cb;
 const err = this._handle.shutdown(req);
 
- if (err === 1) // synchronous finish
+ if (err === 1 || err === UV_ENOTCONN) // synchronous finish
 return afterShutdown.call(req, 0);
 else if (err !== 0)
 return this.destroy(errnoException(err, 'shutdown'));

-Original file line number
+Diff line change
 constassert=require('internal/assert');
 const{
 UV_EADDRINUSE,
 -UV_EINVAL
 +UV_EINVAL,
 +UV_ENOTCONN
 }=internalBinding('uv');
 const{ Buffer }=require('buffer');
 req.callback=cb;
 consterr=this._handle.shutdown(req);
 -if(err===1)// synchronous finish
 +if(err===1||err===UV_ENOTCONN)// synchronous finish
 returnafterShutdown.call(req,0);
 elseif(err!==0)
 returnthis.destroy(errnoException(err,'shutdown'));