repl: check for precise values rather than falsy in loops

Trott · danielleadams · commit dacffd3e9c3a · 2022-03-14T09:32:03.000-04:00
This prepares the code for the no-cond-assign ESLint rule. PR-URL: #41614 Reviewed-By: Tobias Nießen <tniessen@tnie.de> Reviewed-By: Anna Henningsen <anna@addaleax.net>
diff --git a/lib/repl.js b/lib/repl.js
@@ -381,7 +381,7 @@ function REPLServer(prompt,
 paused = false;
 let entry;
 const tmpCompletionEnabled = self.isCompletionEnabled;
- while (entry = ArrayPrototypeShift(pausedBuffer)) {
+ while ((entry = ArrayPrototypeShift(pausedBuffer)) !== undefined) {
 const { 0: type, 1: payload, 2: isCompletionEnabled } = entry;
 switch (type) {
 case 'key': {
@@ -1450,7 +1450,7 @@ function complete(line, callback) {
 ArrayPrototypePush(completionGroups,
 getGlobalLexicalScopeNames(this[kContextId]));
 let contextProto = this.context;
- while (contextProto = ObjectGetPrototypeOf(contextProto)) {
+ while ((contextProto = ObjectGetPrototypeOf(contextProto)) !== null) {
 ArrayPrototypePush(completionGroups,
 filteredOwnPropertyNames(contextProto));
 }

-Original file line number
+Diff line change
 paused=false;
 letentry;
 consttmpCompletionEnabled=self.isCompletionEnabled;
 -while(entry=ArrayPrototypeShift(pausedBuffer)){
 +while((entry=ArrayPrototypeShift(pausedBuffer))!==undefined){
 const{0: type,1: payload,2: isCompletionEnabled}=entry;
 switch(type){
 case'key': {
 ArrayPrototypePush(completionGroups,
 getGlobalLexicalScopeNames(this[kContextId]));
 letcontextProto=this.context;
 -while(contextProto=ObjectGetPrototypeOf(contextProto)){
 +while((contextProto=ObjectGetPrototypeOf(contextProto))!==null){
 ArrayPrototypePush(completionGroups,
 filteredOwnPropertyNames(contextProto));
+}