module: fix check exports issue in cjs module loading

guybedford · MylesBorins · commit db5ec52ea044 · 2020-01-30T17:35:31.000-05:00
Refs: #31001 (comment) PR-URL: #31427 Reviewed-By: Richard Lau <riclau@uk.ibm.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
diff --git a/lib/internal/modules/cjs/loader.js b/lib/internal/modules/cjs/loader.js
@@ -433,7 +433,7 @@ function resolveBasePath(basePath, exts, isMain, trailingSlash, request) {
 
 function trySelf(parentPath, isMain, request) {
 const { data: pkg, path: basePath } = readPackageScope(parentPath) || {};
- if (!pkg || 'exports' in pkg === false) return false;
+ if (!pkg || pkg.exports === undefined) return false;
 if (typeof pkg.name !== 'string') return false;
 
 let expansion;

-Original file line number
+Diff line change
 functiontrySelf(parentPath,isMain,request){
 const{data: pkg,path: basePath}=readPackageScope(parentPath)||{};
 -if(!pkg||'exports'inpkg===false)returnfalse;
 +if(!pkg||pkg.exports===undefined)returnfalse;
 if(typeofpkg.name!=='string')returnfalse;
 letexpansion;