util: inspect: do not crash on an Error stack pointing to itself

PR-URL: #58196
Reviewed-By: Jordan Harband <ljharb@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Ethan Arrowood <ethan@arrowood.dev>

Author: SamVerschueren

lib/internal/util/inspect.js

@@ -1319,7 +1319,12 @@ function getStackString(ctx, error) {
 if(typeoferror.stack==='string'){
 returnerror.stack;
 }
-returnformatValue(ctx,error.stack);
+ctx.seen.push(error);
+ctx.indentationLvl+=4;
+constresult=formatValue(ctx,error.stack);
+ctx.indentationLvl-=4;
+ctx.seen.pop();
+return`${ErrorPrototypeToString(error)}\n ${result}`;
 }
 returnErrorPrototypeToString(error);
 }

test/parallel/test-util-inspect.js

@@ -770,14 +770,14 @@ assert.strictEqual(util.inspect(-5e-324), '-5e-324');
 // Note: Symbols are not supported by `Error#toString()` which is called by
 // accessing the `stack` property.
 [
-[404,'404 [RangeError]: foo','[404]'],
+[404,'404 [RangeError]: foo','[RangeError: foo\n 404]'],
 [0,'0 [RangeError]: foo','[RangeError: foo]'],
 [0n,'0 [RangeError]: foo','[RangeError: foo]'],
 [null,'null: foo','[RangeError: foo]'],
 [undefined,'RangeError: foo','[RangeError: foo]'],
 [false,'false [RangeError]: foo','[RangeError: foo]'],
 ['','foo','[RangeError: foo]'],
-[[1,2,3],'1,2,3 [RangeError]: foo','[[\n 1,\n 2,\n 3\n]]'],
+[[1,2,3],'1,2,3 [RangeError]: foo','[RangeError: foo\n [\n 1,\n 2,\n 3\n]]'],
 ].forEach(([value,outputStart,stack])=>{
 leterr=newRangeError('foo');
 err.name=value;
@@ -3425,6 +3425,34 @@ ${error.stack.split('\n').slice(1).join('\n')}`,
 
 assert.strictEqual(
 inspect(error),
-'[[\n Symbol(foo)\n]]'
+'[Error\n [\n Symbol(foo)\n]]'
 );
 }
+
+{
+constprepareStackTrace=Error.prepareStackTrace;
+
+Error.prepareStackTrace=(error)=>error;
+
+consterror=newError('foo');
+
+assert.strictEqual(inspect(error),'[Error: foo\n [Circular *1]]');
+
+Error.prepareStackTrace=prepareStackTrace;
+}
+
+{
+consterror=newError('foo');
+error.stack=error;
+
+assert.strictEqual(inspect(error),'[Error: foo\n [Circular *1]]');
+}
+
+{
+consterror=newError('foo');
+consterror2=newError('bar');
+error.stack=error2;
+error2.stack=error;
+
+assert.strictEqual(inspect(error),'[Error: foo\n [Error: bar\n [Circular *1]]]');
+}