benchmark: refactor buffer benchmarks

Currently the buffer benchmarks take significantly too long to
complete. This drastically reduces the overall runtime by removing
obsolete checked variations and reducing the iteration count.
It also improves the benchmarks by removing the deprecated
`new Buffer(size)` usage and some other small improvements.
PR-URL: #26418
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
Reviewed-By: Peter Marshall <petermarshall@chromium.org>
Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: BridgeAR

benchmark/buffers/buffer-bytelength.js

@@ -3,8 +3,8 @@ const common = require('../common');
 
 constbench=common.createBenchmark(main,{
 encoding: ['utf8','base64','buffer'],
-len: [1,2,4,16,64,256],// x16
-n: [5e6]
+len: [2,16,256],// x16
+n: [4e6]
 });
 
 // 16 chars each

benchmark/buffers/buffer-compare-instance-method.js

@@ -2,8 +2,8 @@
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{
-size: [16,512,1024,4096,16386],
-args: [1,2,3,4,5],
+size: [16,512,4096,16386],
+args: [1,2,5],
 n: [1e6]
 });
 
@@ -16,22 +16,6 @@ function main({ n, size, args }) {
 
 b1[size-1]='b'.charCodeAt(0);
 
-switch(args){
-case2:
-b0.compare(b1,0);
-break;
-case3:
-b0.compare(b1,0,b1Len);
-break;
-case4:
-b0.compare(b1,0,b1Len,0);
-break;
-case5:
-b0.compare(b1,0,b1Len,0,b0Len);
-break;
-default:
-b0.compare(b1);
-}
 switch(args){
 case2:
 b0.compare(b1,0);

benchmark/buffers/buffer-compare-offset.js

@@ -3,7 +3,7 @@ const common = require('../common.js');
 
 constbench=common.createBenchmark(main,{
 method: ['offset','slice'],
-size: [16,512,1024,4096,16386],
+size: [16,512,4096,16386],
 n: [1e6]
 });
 

benchmark/buffers/buffer-compare.js

@@ -23,7 +23,7 @@
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{
-size: [16,512,1024,4096,16386],
+size: [16,512,4096,16386],
 n: [1e6]
 });
 

benchmark/buffers/buffer-concat.js

@@ -2,20 +2,20 @@
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{
-pieces: [1,4,16],
+pieces: [4,16],
 pieceSize: [1,16,256],
 withTotalLength: [0,1],
-n: [1024]
+n: [8e5]
 });
 
 functionmain({ n, pieces, pieceSize, withTotalLength }){
-constlist=newArray(pieces);
-list.fill(Buffer.allocUnsafe(pieceSize));
+constlist=Array.from({length: pieces})
+.fill(Buffer.allocUnsafe(pieceSize));
 
 consttotalLength=withTotalLength ? pieces*pieceSize : undefined;
 
 bench.start();
-for(vari=0;i<n*1024;i++){
+for(vari=0;i<n;i++){
 Buffer.concat(list,totalLength);
 }
 bench.end(n);

benchmark/buffers/buffer-creation.js

@@ -1,5 +1,4 @@
 'use strict';
-constSlowBuffer=require('buffer').SlowBuffer;
 
 constcommon=require('../common.js');
 constassert=require('assert');
@@ -9,10 +8,9 @@ const bench = common.createBenchmark(main, {
 'fast-alloc-fill',
 'fast-allocUnsafe',
 'slow-allocUnsafe',
-'slow',
-'buffer()'],
-len: [10,1024,2048,4096,8192],
-n: [1024]
+],
+len: [10,1024,4096,8192],
+n: [6e5]
 });
 
 functionmain({ len, n, type }){
@@ -24,7 +22,7 @@ function main({ len, n, type }) {
 break;
 case'fast-alloc-fill':
 bench.start();
-for(i=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.alloc(len,0);
 }
 bench.end(n);
@@ -35,18 +33,12 @@ function main({ len, n, type }) {
 case'slow-allocUnsafe':
 fn=Buffer.allocUnsafeSlow;
 break;
-case'slow':
-fn=SlowBuffer;
-break;
-case'buffer()':
-fn=Buffer;
-break;
 default:
 assert.fail('Should not get here');
 }
 
 bench.start();
-for(i=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 fn(len);
 }
 bench.end(n);

benchmark/buffers/buffer-fill.js

@@ -14,7 +14,7 @@ const bench = common.createBenchmark(main, {
 'fill("t", 0)',
 'fill(Buffer.alloc(1), 0)',
 ],
-size: [2**8,2**13,2**16],
+size: [2**13,2**16],
 n: [2e4]
 });
 

benchmark/buffers/buffer-from.js

@@ -8,14 +8,13 @@ const bench = common.createBenchmark(main, {
 'arraybuffer',
 'arraybuffer-middle',
 'buffer',
-'uint8array',
 'string',
 'string-utf8',
 'string-base64',
 'object',
 ],
-len: [10,2048],
-n: [2048]
+len: [100,2048],
+n: [8e5]
 });
 
 functionmain({ len, n, source }){
@@ -26,17 +25,19 @@ function main({ len, n, source }) {
 constuint8array=newUint8Array(len);
 constobj={length: null};// Results in a new, empty Buffer
 
+leti=0;
+
 switch(source){
 case'array':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(array);
 }
 bench.end(n);
 break;
 case'arraybuffer':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(arrayBuf);
 }
 bench.end(n);
@@ -45,49 +46,49 @@ function main({ len, n, source }) {
 constoffset=~~(len/4);
 constlength=~~(len/2);
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(arrayBuf,offset,length);
 }
 bench.end(n);
 break;
 case'buffer':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(buffer);
 }
 bench.end(n);
 break;
 case'uint8array':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(uint8array);
 }
 bench.end(n);
 break;
 case'string':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(str);
 }
 bench.end(n);
 break;
 case'string-utf8':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(str,'utf8');
 }
 bench.end(n);
 break;
 case'string-base64':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(str,'base64');
 }
 bench.end(n);
 break;
 case'object':
 bench.start();
-for(leti=0;i<n*1024;i++){
+for(i=0;i<n;i++){
 Buffer.from(obj);
 }
 bench.end(n);

benchmark/buffers/buffer-hex.js

@@ -3,8 +3,8 @@
 constcommon=require('../common.js');
 
 constbench=common.createBenchmark(main,{
-len: [0,1,64,1024],
-n: [1e7]
+len: [64,1024],
+n: [1e6]
 });
 
 functionmain({ len, n }){

benchmark/buffers/buffer-indexof-number.js

@@ -5,17 +5,19 @@ const path = require('path');
 
 constbench=common.createBenchmark(main,{
 value: ['@'.charCodeAt(0)],
-n: [1e7]
+n: [1e6]
 });
 
 functionmain({ n, value }){
 constaliceBuffer=fs.readFileSync(
 path.resolve(__dirname,'../fixtures/alice.html')
 );
 
+letcount=0;
 bench.start();
 for(vari=0;i<n;i++){
-aliceBuffer.indexOf(value,0,undefined);
+count+=aliceBuffer.indexOf(value,0,undefined);
 }
 bench.end(n);
+returncount;
 }