test: remove lint rule for setTimeout() arguments

With the introduction of the promises API for setTimeout(), the
requirement that it have two parameters may not be sensible anymore in
tests.
PR-URL: #41901
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Mestery <mestery@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: Trott

test/.eslintrc.yaml

@@ -31,8 +31,6 @@ rules:
 message: "Use an object as second argument of `assert.throws()`."
  - selector: "CallExpression:matches([callee.name='throws'], [callee.property.name='throws'])[arguments.length<2]"
 message: "`assert.throws()` must be invoked with at least two arguments."
- - selector: "CallExpression[callee.name='setTimeout'][arguments.length<2]"
-message: "`setTimeout()` must be invoked with at least two arguments."
  - selector: "CallExpression[callee.name='setInterval'][arguments.length<2]"
 message: "`setInterval()` must be invoked with at least two arguments."
  - selector: "ThrowStatement > CallExpression[callee.name=/Error$/]"

test/parallel/test-stream-construct-async-error.js

@@ -12,7 +12,6 @@ const assert = require('assert');
 {
 classFooextendsDuplex{
 async_destroy(err,cb){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 thrownewError('boom');
 }
@@ -31,7 +30,6 @@ const assert = require('assert');
 {
 classFooextendsDuplex{
 async_destroy(err,cb){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 }
 }
@@ -46,7 +44,6 @@ const assert = require('assert');
 {
 classFooextendsDuplex{
 async_construct(){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 }
 
@@ -64,7 +61,6 @@ const assert = require('assert');
 {
 classFooextendsDuplex{
 async_construct(callback){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 callback();
 }
@@ -88,7 +84,6 @@ const assert = require('assert');
 });
 
 async_final(){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 }
 }
@@ -105,7 +100,6 @@ const assert = require('assert');
 });
 
 async_final(callback){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 callback();
 }
@@ -123,7 +117,6 @@ const assert = require('assert');
 });
 
 async_final(){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 thrownewError('boom');
 }

test/parallel/test-stream-some-find-every.mjs

@@ -59,7 +59,6 @@ function oneTo5Async() {
 
 {
 asyncfunctioncheckDestroyed(stream){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout();
 assert.strictEqual(stream.destroyed,true);
 }
@@ -109,7 +108,6 @@ function oneTo5Async() {
 // Concurrency doesn't affect which value is found.
 constfound=awaitReadable.from([1,2]).find(async(val)=>{
 if(val===1){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(100);
 }
 returntrue;

test/parallel/test-stream-writable-final-async.js

@@ -9,7 +9,6 @@ const { setTimeout } = require('timers/promises');
 {
 classFooextendsDuplex{
 async_final(callback){
-// eslint-disable-next-line no-restricted-syntax
 awaitsetTimeout(common.platformTimeout(1));
 callback();
 }