test_runner: support defining test reporter in NODE_OPTIONS

Adds --test-reporter and --test-reporter-destination as
allowable options in NODE_OPTIONS. Also adds the CLI flag
--test-child-process to allow forcing the default
test-reporter for inter-process communication.
Fixes: #46484
PR-URL: #46688
Reviewed-By: Moshe Atlow <moshe@atlow.co.il>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: SRHerzog

doc/api/cli.md

@@ -1915,6 +1915,8 @@ Node.js options that are allowed are:
 *`--secure-heap`
 *`--snapshot-blob`
 *`--test-only`
+*`--test-reporter-destination`
+*`--test-reporter`
 *`--throw-deprecation`
 *`--title`
 *`--tls-cipher-list`
@@ -2056,6 +2058,11 @@ If `value` equals `'1'`, the check for a supported platform is skipped during
 Node.js startup. Node.js might not execute correctly. Any issues encountered
 on unsupported platforms will not be fixed.
 
+### `NODE_TEST_CONTEXT=value`
+
+If `value` equals `'child'`, test reporter options will be overridden and test
+output will be sent to stdout in the TAP format.
+
 ### `NODE_TLS_REJECT_UNAUTHORIZED=value`
 
 If `value` equals `'0'`, certificate validation is disabled for TLS connections.

lib/internal/test_runner/runner.js

@@ -144,6 +144,7 @@ function getRunArgs({ path, inspectPort }) {
 ArrayPrototypePush(argv,`--inspect-port=${getInspectPort(inspectPort)}`);
 }
 ArrayPrototypePush(argv,path);
+
 returnargv;
 }
 
@@ -259,7 +260,7 @@ function runTestFile(path, root, inspectPort, filesWatcher) {
 constsubtest=root.createSubtest(FileTest,path,async(t)=>{
 constargs=getRunArgs({ path, inspectPort });
 conststdio=['pipe','pipe','pipe'];
-constenv={ ...process.env};
+constenv={ ...process.env,NODE_TEST_CONTEXT: 'child'};
 if(filesWatcher){
 stdio.push('ipc');
 env.WATCH_REPORT_DEPENDENCIES='1';

lib/internal/test_runner/utils.js

@@ -9,6 +9,7 @@ const {
  RegExpPrototypeExec,
  SafeMap,
 }=primordials;
+
 const{ basename }=require('path');
 const{ createWriteStream }=require('fs');
 const{ pathToFileURL }=require('internal/url');
@@ -167,25 +168,33 @@ function parseCommandLine() {
 
 constisTestRunner=getOptionValue('--test');
 constcoverage=getOptionValue('--experimental-test-coverage');
-constdestinations=getOptionValue('--test-reporter-destination');
-constreporters=getOptionValue('--test-reporter');
+constisChildProcess=process.env.NODE_TEST_CONTEXT==='child';
+letdestinations;
+letreporters;
 lettestNamePatterns;
 lettestOnlyFlag;
 
-if(reporters.length===0&&destinations.length===0){
-ArrayPrototypePush(reporters,kDefaultReporter);
-}
+if(isChildProcess){
+reporters=[kDefaultReporter];
+destinations=[kDefaultDestination];
+}else{
+destinations=getOptionValue('--test-reporter-destination');
+reporters=getOptionValue('--test-reporter');
+if(reporters.length===0&&destinations.length===0){
+ArrayPrototypePush(reporters,kDefaultReporter);
+}
 
-if(reporters.length===1&&destinations.length===0){
-ArrayPrototypePush(destinations,kDefaultDestination);
-}
+if(reporters.length===1&&destinations.length===0){
+ArrayPrototypePush(destinations,kDefaultDestination);
+}
 
-if(destinations.length!==reporters.length){
-thrownewERR_INVALID_ARG_VALUE(
-'--test-reporter',
-reporters,
-'must match the number of specified \'--test-reporter-destination\'',
-);
+if(destinations.length!==reporters.length){
+thrownewERR_INVALID_ARG_VALUE(
+'--test-reporter',
+reporters,
+'must match the number of specified \'--test-reporter-destination\'',
+);
+}
 }
 
 if(isTestRunner){

src/node_options.cc

@@ -574,10 +574,12 @@ EnvironmentOptionsParser::EnvironmentOptionsParser() {
  &EnvironmentOptions::test_name_pattern);
 AddOption("--test-reporter",
 "report test output using the given reporter",
- &EnvironmentOptions::test_reporter);
+ &EnvironmentOptions::test_reporter,
+kAllowedInEnvvar);
 AddOption("--test-reporter-destination",
 "report given reporter to the given destination",
- &EnvironmentOptions::test_reporter_destination);
+ &EnvironmentOptions::test_reporter_destination,
+kAllowedInEnvvar);
 AddOption("--test-only",
 "run tests with 'only' option set",
  &EnvironmentOptions::test_only,