stream: allow shared array buffer sources in writable webstream adapter

Refs: #61913
Signed-off-by: Renegade334 <contact.9a5d6388@renegade334.me.uk>
PR-URL: #62163
Reviewed-By: Filip Skokan <panva.ip@gmail.com>

Author: Renegade334

lib/internal/webstreams/adapters.js

@@ -56,7 +56,7 @@ const {
 }=require('buffer');
 
 const{
-isArrayBuffer,
+isAnyArrayBuffer,
 }=require('internal/util/types');
 
 const{
@@ -230,11 +230,11 @@ function newWritableStreamFromStreamWritable(streamWritable, options = kEmptyObj
 start(c){controller=c;},
 
 write(chunk){
-if(!streamWritable.writableObjectMode&&isArrayBuffer(chunk)){
-chunk=newUint8Array(chunk);
-}
 try{
 options[kValidateChunk]?.(chunk);
+if(!streamWritable.writableObjectMode&&isAnyArrayBuffer(chunk)){
+chunk=newUint8Array(chunk);
+}
 if(streamWritable.writableNeedDrain||!streamWritable.write(chunk)){
 backpressurePromise=PromiseWithResolvers();
 returnSafePromisePrototypeFinally(

lib/internal/webstreams/compression.js

@@ -40,7 +40,7 @@ function lazyZlib() {
 // Per the Compression Streams spec, chunks must be BufferSource
 // (ArrayBuffer or ArrayBufferView not backed by SharedArrayBuffer).
 functionvalidateBufferSourceChunk(chunk){
-if(isArrayBufferView(chunk)&&isSharedArrayBuffer(chunk.buffer)){
+if(isSharedArrayBuffer(isArrayBufferView(chunk)? chunk.buffer : chunk)){
 thrownewERR_INVALID_ARG_TYPE(
 'chunk',
 ['ArrayBuffer','Buffer','TypedArray','DataView'],

test/parallel/test-webstreams-adapters-writable-buffer-sources.js

@@ -0,0 +1,95 @@
+'use strict';
+constcommon=require('../common');
+
+constassert=require('assert');
+const{ Buffer }=require('buffer');
+const{ Duplex, Writable }=require('stream');
+const{ suite, test }=require('node:test');
+
+constctors=[ArrayBuffer,SharedArrayBuffer];
+
+suite('underlying Writable',()=>{
+suite('in non-object mode',()=>{
+for(constctorofctors){
+test(`converts ${ctor.name} chunks`,async()=>{
+constbuffer=newctor(4);
+constwritable=newWritable({
+objectMode: false,
+write: common.mustCall((chunk,encoding,callback)=>{
+assert(Buffer.isBuffer(chunk));
+assert.strictEqual(chunk.buffer,buffer);
+callback();
+}),
+});
+writable.on('error',common.mustNotCall());
+constwriter=Writable.toWeb(writable).getWriter();
+awaitwriter.write(buffer);
+});
+}
+});
+
+suite('in object mode',()=>{
+for(constctorofctors){
+test(`passes through ${ctor.name} chunks`,async()=>{
+constbuffer=newctor(4);
+constwritable=newWritable({
+objectMode: true,
+write: common.mustCall((chunk,encoding,callback)=>{
+assert(chunkinstanceofctor);
+assert.strictEqual(chunk,buffer);
+callback();
+}),
+});
+writable.on('error',common.mustNotCall());
+constwriter=Writable.toWeb(writable).getWriter();
+awaitwriter.write(buffer);
+});
+}
+});
+});
+
+suite('underlying Duplex',()=>{
+suite('in non-object mode',()=>{
+for(constctorofctors){
+test(`converts ${ctor.name} chunks`,async()=>{
+constbuffer=newctor(4);
+constduplex=newDuplex({
+writableObjectMode: false,
+write: common.mustCall((chunk,encoding,callback)=>{
+assert(Buffer.isBuffer(chunk));
+assert.strictEqual(chunk.buffer,buffer);
+callback();
+}),
+read(){
+this.push(null);
+},
+});
+duplex.on('error',common.mustNotCall());
+constwriter=Duplex.toWeb(duplex).writable.getWriter();
+awaitwriter.write(buffer);
+});
+}
+});
+
+suite('in object mode',()=>{
+for(constctorofctors){
+test(`passes through ${ctor.name} chunks`,async()=>{
+constbuffer=newctor(4);
+constduplex=newDuplex({
+writableObjectMode: true,
+write: common.mustCall((chunk,encoding,callback)=>{
+assert(chunkinstanceofctor);
+assert.strictEqual(chunk,buffer);
+callback();
+}),
+read(){
+this.push(null);
+},
+});
+duplex.on('error',common.mustNotCall());
+constwriter=Duplex.toWeb(duplex).writable.getWriter();
+awaitwriter.write(buffer);
+});
+}
+});
+});