child_process: use /system/bin/sh on android

bnoordhuis · evanlucas · commit e0240ab59207 · 2016-05-17T08:52:48.000-05:00
`/bin/sh` does not exist on Android but `/system/bin/sh` does. PR-URL: #6745 Refs: #6733 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com>
diff --git a/lib/child_process.js b/lib/child_process.js
@@ -332,7 +332,12 @@ function normalizeSpawnArguments(file /*, args, options*/) {
 args = ['/s', '/c', '"' + command + '"'];
 options.windowsVerbatimArguments = true;
 } else {
- file = typeof options.shell === 'string' ? options.shell : '/bin/sh';
+ if (typeof options.shell === 'string')
+ file = options.shell;
+ else if (process.platform === 'android')
+ file = '/system/bin/sh';
+ else
+ file = '/bin/sh';
 args = ['-c', command];
 }
 }

Original file line number	Diff line number	Diff line change
`@@ -332,7 +332,12 @@ function normalizeSpawnArguments(file /, args, options/) {`
`332`	`332`	`args=['/s','/c','"'+command+'"'];`
`333`	`333`	`options.windowsVerbatimArguments=true;`
`334`	`334`	`}else{`
`335`		`-file=typeofoptions.shell==='string' ? options.shell : '/bin/sh';`
	`335`	`+if(typeofoptions.shell==='string')`
	`336`	`+file=options.shell;`
	`337`	`+elseif(process.platform==='android')`
	`338`	`+file='/system/bin/sh';`
	`339`	`+else`
	`340`	`+file='/bin/sh';`
`336`	`341`	`args=['-c',command];`
`337`	`342`	`}`
`338`	`343`	`}`