test: check noop function invocations

In test/pummel/test-stream2-basic.js, check that noop functions are
called the expected number of times.
PR-URL: #13146
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>

Author: Trott

test/pummel/test-stream2-basic.js

@@ -125,7 +125,7 @@ test('a most basic test', function(t) {
 'xxxxxxxxxxxxxxxxxxxxx'];
 
 r.on('end',function(){
-t.same(reads,expect);
+assert.deepStrictEqual(reads,expect);
 t.end();
 });
 
@@ -158,7 +158,7 @@ test('pipe', function(t) {
 constw=newTestWriter();
 
 w.on('end',function(received){
-t.same(received,expect);
+assert.deepStrictEqual(received,expect);
 t.end();
 });
 
@@ -204,15 +204,15 @@ test('pipe', function(t) {
 t.equal(ended0,false);
 ended0=true;
 ended++;
-t.same(results,expect[0]);
+assert.deepStrictEqual(results,expect[0]);
 });
 
 w[1].on('end',function(results){
 t.equal(ended1,false);
 ended1=true;
 ended++;
 t.equal(ended,2);
-t.same(results,expect[1]);
+assert.deepStrictEqual(results,expect[1]);
 t.end();
 });
 
@@ -239,11 +239,11 @@ test('multipipe', function(t) {
 
 letc=2;
 w[0].on('end',function(received){
-t.same(received,expect,'first');
+assert.deepStrictEqual(received,expect,'first');
 if(--c===0)t.end();
 });
 w[1].on('end',function(received){
-t.same(received,expect,'second');
+assert.deepStrictEqual(received,expect,'second');
 if(--c===0)t.end();
 });
 
@@ -284,13 +284,13 @@ test('multipipe', function(t) {
 
 w[0].on('end',function(results){
 ended++;
-t.same(results,expect[0]);
+assert.deepStrictEqual(results,expect[0]);
 });
 
 w[1].on('end',function(results){
 ended++;
 t.equal(ended,2);
-t.same(results,expect[1]);
+assert.deepStrictEqual(results,expect[1]);
 t.end();
 });
 
@@ -300,10 +300,8 @@ test('multipipe', function(t) {
 });
 
 test('back pressure respected',function(t){
-functionnoop(){}
-
 constr=newR({objectMode: true});
-r._read=noop;
+r._read=common.mustNotCall();
 letcounter=0;
 r.push(['one']);
 r.push(['two']);
@@ -321,7 +319,7 @@ test('back pressure respected', function(t) {
 r.pipe(w3);
 });
 };
-w1.end=noop;
+w1.end=common.mustNotCall();
 
 r.pipe(w1);
 
@@ -347,7 +345,7 @@ test('back pressure respected', function(t) {
 
 returnfalse;
 };
-w2.end=noop;
+w2.end=common.mustCall();
 
 letw3=newR();
 w3.write=function(chunk){
@@ -380,7 +378,7 @@ test('read(0) for ended streams', function(t) {
 constr=newR();
 letwritten=false;
 letended=false;
-r._read=function(n){};
+r._read=common.mustNotCall();
 
 r.push(Buffer.from('foo'));
 r.push(null);
@@ -451,7 +449,7 @@ test('adding readable triggers data flow', function(t) {
 
 test('chainable',function(t){
 constr=newR();
-r._read=common.noop;
+r._read=common.mustCall();
 constr2=r.setEncoding('utf8').pause().resume().pause();
 t.equal(r,r2);
 t.end();