module: load ESM helpers eagerly in the snapshot

Since the ESM loader is captured in the snapshot now, there's
no need to lazy load the helpers. Load them eagerly to capture
them into the snapshot. This also reduces the noise coming out
of --print-bytecode since we no longer compile the helper
functions at run time.
Signed-off-by: Joyee Cheung <joyeec9h3@gmail.com>
PR-URL: #63550
Reviewed-By: Chengzhong Wu <legendecas@gmail.com>
Reviewed-By: Geoffrey Booth <webadmin@geoffreybooth.com>

Author: joyeecheung

lib/internal/modules/esm/loader.js

@@ -14,7 +14,8 @@ const {
  hardenRegExp,
 }=primordials;
 
-
+const{ LoadCache, ResolveCache }=require('internal/modules/esm/module_map');
+const{ ModuleJob, ModuleJobSync }=require('internal/modules/esm/module_job');
 // This is needed to avoid cycles in esm/resolve <-> cjs/loader
 const{
  kIsExecuting,
@@ -85,24 +86,6 @@ const { isPromise } = require('internal/util/types');
  * @typedef {import('url').URL} URL
  */
 
-/**
- * Lazy loads the module_map module and returns a new instance of ResolveCache.
- * @returns {import('./module_map.js').ResolveCache}
- */
-functionnewResolveCache(){
-const{ ResolveCache }=require('internal/modules/esm/module_map');
-returnnewResolveCache();
-}
-
-/**
- * Generate a load cache (to store the final result of a load-chain for a particular module).
- * @returns {import('./module_map.js').LoadCache}
- */
-functionnewLoadCache(){
-const{ LoadCache }=require('internal/modules/esm/module_map');
-returnnewLoadCache();
-}
-
 const{ translators }=require('internal/modules/esm/translators');
 const{ defaultResolve }=require('internal/modules/esm/resolve');
 const{ defaultLoadSync, throwUnknownModuleFormat }=require('internal/modules/esm/load');
@@ -161,12 +144,12 @@ class ModuleLoader {
 /**
  * Registry of resolved specifiers
  */
- #resolveCache =newResolveCache();
+ #resolveCache =newResolveCache();
 
 /**
  * Registry of loaded modules, akin to `require.cache`
  */
-loadCache=newLoadCache();
+loadCache=newLoadCache();
 
 /**
  * @see {AsyncLoaderHooks.isForAsyncLoaderHookWorker}
@@ -238,7 +221,6 @@ class ModuleLoader {
  * @returns {Promise<object>} The module object.
  */
 asyncexecuteModuleJob(url,wrap,isEntryPoint=false){
-const{ ModuleJob }=require('internal/modules/esm/module_job');
 constmodule=awaitonImport.tracePromise(async()=>{
 constjob=newModuleJob(this,url,undefined,wrap,kEvaluationPhase,false,false,kImportInImportedESM);
 this.loadCache.set(url,undefined,job);
@@ -357,7 +339,6 @@ class ModuleLoader {
 constwrap=compileSourceTextModule(url,source,kUser);
 constinspectBrk=(isMain&&getOptionValue('--inspect-brk'));
 
-const{ ModuleJobSync }=require('internal/modules/esm/module_job');
 job=newModuleJobSync(this,url,kEmptyObject,wrap,kEvaluationPhase,isMain,inspectBrk,
 kImportInRequiredESM);
 this.loadCache.set(url,kImplicitTypeAttribute,job);
@@ -587,7 +568,6 @@ class ModuleLoader {
 assert(moduleOrModulePromiseinstanceofModuleWrap,`Expected ModuleWrap for loading ${url}`);
 }
 
-const{ ModuleJob, ModuleJobSync }=require('internal/modules/esm/module_job');
 // TODO(joyeecheung): use ModuleJobSync for kRequireInImportedCJS too.
 constModuleJobCtor=(requestType===kImportInRequiredESM ? ModuleJobSync : ModuleJob);
 constisMain=(parentURL===undefined);

test/parallel/test-bootstrap-modules.js

@@ -133,6 +133,8 @@ if (isMainThread) {
 'NativeModule internal/modules/esm/load',
 'NativeModule internal/modules/esm/resolve',
 'NativeModule internal/modules/esm/translators',
+'NativeModule internal/modules/esm/module_job',
+'NativeModule internal/modules/esm/module_map',
 'NativeModule url',
 ].forEach(expected.beforePreExec.add.bind(expected.beforePreExec));
 }else{// Worker.