Revert "fs: add v8 fast api to closeSync"

This reverts commit ed6f45b.
PR-URL: #53904
Refs: yarnpkg/berry#6398
Refs: npm/cli#7657
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: avivkeller

src/env.cc

@@ -1841,23 +1841,12 @@ void Environment::AddUnmanagedFd(int fd) {
  }
 }
 
-voidEnvironment::RemoveUnmanagedFd(int fd, bool schedule_native_immediate) {
+voidEnvironment::RemoveUnmanagedFd(int fd) {
 if (!tracks_unmanaged_fds()) return;
 size_t removed_count = unmanaged_fds_.erase(fd);
 if (removed_count == 0) {
-if (schedule_native_immediate) {
-SetImmediateThreadsafe([&](Environment* env) {
-ProcessEmitWarning(this,
-"File descriptor %d closed but not opened in "
-"unmanaged mode",
- fd);
- });
- } else {
-ProcessEmitWarning(
-this,
-"File descriptor %d closed but not opened in unmanaged mode",
- fd);
- }
+ProcessEmitWarning(
+this, "File descriptor %d closed but not opened in unmanaged mode", fd);
  }
 }
 

src/env.h

@@ -1027,7 +1027,7 @@ class Environment : public MemoryRetainer {
  std::unique_ptr<v8::BackingStore> release_managed_buffer(constuv_buf_t& buf);
 
 voidAddUnmanagedFd(int fd);
-voidRemoveUnmanagedFd(int fd, bool schedule_native_immediate = false);
+voidRemoveUnmanagedFd(int fd);
 
 template <typename T>
 voidForEachRealm(T&& iterator) const;

src/node_external_reference.h

@@ -47,9 +47,6 @@ using CFunctionCallbackWithUint8ArrayUint32Int64Bool =
 uint32_t,
 int64_t,
 bool);
-using CFunctionWithObjectInt32Fallback = void (*)(v8::Local<v8::Object>,
-int32_t input,
- v8::FastApiCallbackOptions&);
 using CFunctionWithUint32 = uint32_t (*)(v8::Local<v8::Value>,
 constuint32_t input);
 using CFunctionWithDoubleReturnDouble = double (*)(v8::Local<v8::Value>,
@@ -78,7 +75,6 @@ class ExternalReferenceRegistry {
 V(CFunctionCallbackWithTwoUint8Arrays) \
 V(CFunctionCallbackWithTwoUint8ArraysFallback) \
 V(CFunctionCallbackWithUint8ArrayUint32Int64Bool) \
-V(CFunctionWithObjectInt32Fallback) \
 V(CFunctionWithUint32) \
 V(CFunctionWithDoubleReturnDouble) \
 V(CFunctionWithInt64Fallback) \

src/node_file.cc

@@ -54,7 +54,6 @@ namespace fs {
 
 using v8::Array;
 using v8::BigInt;
-using v8::CFunction;
 using v8::Context;
 using v8::EscapableHandleScope;
 using v8::FastApiCallbackOptions;
@@ -299,7 +298,7 @@ FileHandle::TransferData::~TransferData() {
 
 BaseObjectPtr<BaseObject> FileHandle::TransferData::Deserialize(
  Environment* env,
- Local<v8::Context> context,
+v8::Local<v8::Context> context,
  std::unique_ptr<worker::TransferData> self) {
  BindingData* bd = Realm::GetBindingData<BindingData>(context);
 if (bd == nullptr) return {};
@@ -961,7 +960,7 @@ void Access(const FunctionCallbackInfo<Value>& args) {
  }
 }
 
-staticvoidClose(const FunctionCallbackInfo<Value>& args) {
+voidClose(const FunctionCallbackInfo<Value>& args) {
  Environment* env = Environment::GetCurrent(args);
 
 constint argc = args.Length();
@@ -987,30 +986,6 @@ static void Close(const FunctionCallbackInfo<Value>& args) {
  }
 }
 
-staticvoidFastClose(Local<Object> recv,
-int32_t fd,
-// NOLINTNEXTLINE(runtime/references) This is V8 api.
- v8::FastApiCallbackOptions& options) {
- Environment* env = Environment::GetCurrent(recv->GetCreationContextChecked());
-
-uv_fs_t req;
-FS_SYNC_TRACE_BEGIN(close);
-int err = uv_fs_close(nullptr, &req, fd, nullptr) < 0;
-FS_SYNC_TRACE_END(close);
-uv_fs_req_cleanup(&req);
-
-if (err < 0) {
- options.fallback = true;
- } else {
-// Note: Only remove unmanaged fds if the close was successful.
-// RemoveUnmanagedFd() can call ProcessEmitWarning() which calls back into
-// JS process.emitWarning() and violates the fast API protocol.
- env->RemoveUnmanagedFd(fd, true/* schedule native immediate */);
- }
-}
-
-CFunction fast_close_ = CFunction::Make(FastClose);
-
 staticvoidExistsSync(const FunctionCallbackInfo<Value>& args) {
  Environment* env = Environment::GetCurrent(args);
  Isolate* isolate = env->isolate();
@@ -3330,7 +3305,7 @@ static void CreatePerIsolateProperties(IsolateData* isolate_data,
 "getFormatOfExtensionlessFile",
  GetFormatOfExtensionlessFile);
 SetMethod(isolate, target, "access", Access);
-SetFastMethod(isolate, target, "close", Close, &fast_close_);
+SetMethod(isolate, target, "close", Close);
 SetMethod(isolate, target, "existsSync", ExistsSync);
 SetMethod(isolate, target, "open", Open);
 SetMethod(isolate, target, "openFileHandle", OpenFileHandle);
@@ -3455,8 +3430,6 @@ void RegisterExternalReferences(ExternalReferenceRegistry* registry) {
 
  registry->Register(GetFormatOfExtensionlessFile);
  registry->Register(Close);
- registry->Register(FastClose);
- registry->Register(fast_close_.GetTypeInfo());
  registry->Register(ExistsSync);
  registry->Register(Open);
  registry->Register(OpenFileHandle);