timers: named anonymous functions

js-kyle · MylesBorins · commit e552158dd261 · 2018-05-08T14:22:25.000-07:00
PR-URL: #20397 Refs: #8913 Reviewed-By: Anatoli Papirovski <apapirovski@mac.com> Reviewed-By: Minwoo Jung <minwoo@nodesource.com> Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Tiancheng "Timothy" Gu <timothygu99@gmail.com>
diff --git a/lib/timers.js b/lib/timers.js
@@ -453,7 +453,7 @@ function rearm(timer, start = TimerWrap.now()) {
 }
 
 
-const clearTimeout = exports.clearTimeout = function(timer) {
+const clearTimeout = exports.clearTimeout = function clearTimeout(timer) {
 if (timer && timer._onTimeout) {
 timer._onTimeout = null;
 if (timer instanceof Timeout) {
@@ -465,7 +465,7 @@ const clearTimeout = exports.clearTimeout = function(timer) {
 };
 
 
-exports.setInterval = function(callback, repeat, arg1, arg2, arg3) {
+exports.setInterval = function setInterval(callback, repeat, arg1, arg2, arg3) {
 if (typeof callback !== 'function') {
 throw new ERR_INVALID_CALLBACK();
 }
@@ -774,7 +774,7 @@ setImmediate[internalUtil.promisify.custom] = function(value) {
 exports.setImmediate = setImmediate;
 
 
-exports.clearImmediate = function(immediate) {
+exports.clearImmediate = function clearImmediate(immediate) {
 if (!immediate || immediate._destroyed)
 return;
 

-Original file line number
+Diff line change
+}
 -constclearTimeout=exports.clearTimeout=function(timer){
 +constclearTimeout=exports.clearTimeout=functionclearTimeout(timer){
 if(timer&&timer._onTimeout){
 timer._onTimeout=null;
 if(timerinstanceofTimeout){
 };
 -exports.setInterval=function(callback,repeat,arg1,arg2,arg3){
 +exports.setInterval=functionsetInterval(callback,repeat,arg1,arg2,arg3){
 if(typeofcallback!=='function'){
 thrownewERR_INVALID_CALLBACK();
+}
 exports.setImmediate=setImmediate;
 -exports.clearImmediate=function(immediate){
 +exports.clearImmediate=functionclearImmediate(immediate){
 if(!immediate||immediate._destroyed)
 return;