http: reuse noop function in socketOnError()

cjihrig · addaleax · commit e55c5c341dd3 · 2019-01-23T19:32:03.000+01:00
PR-URL: #25566 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
diff --git a/lib/_http_server.js b/lib/_http_server.js
@@ -499,13 +499,14 @@ function onParserExecute(server, socket, parser, state, ret) {
 onParserExecuteCommon(server, socket, parser, state, ret, undefined);
 }
 
+const noop = () => {};
 const badRequestResponse = Buffer.from(
 `HTTP/1.1 400 ${STATUS_CODES[400]}${CRLF}${CRLF}`, 'ascii'
 );
 function socketOnError(e) {
 // Ignore further errors
 this.removeListener('error', socketOnError);
- this.on('error', () => {});
+ this.on('error', noop);
 
 if (!this.server.emit('clientError', e, this)) {
 if (this.writable) {

-Original file line number
+Diff line change
 onParserExecuteCommon(server,socket,parser,state,ret,undefined);
+}
 +constnoop=()=>{};
 constbadRequestResponse=Buffer.from(
 `HTTP/1.1 400 ${STATUS_CODES[400]}${CRLF}${CRLF}`,'ascii'
 );
 functionsocketOnError(e){
 // Ignore further errors
 this.removeListener('error',socketOnError);
 -this.on('error',()=>{});
 +this.on('error',noop);
 if(!this.server.emit('clientError',e,this)){
 if(this.writable){