fs: refactor promises version of lchown and lchmod

cjihrig · MylesBorins · commit e5a0c197bde5 · 2018-05-22T14:09:48.000-04:00
Check for platform support first to save a level of indentation. PR-URL: #20551 Reviewed-By: Сковорода Никита Андреевич <chalkerx@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Refael Ackermann <refack@gmail.com>
diff --git a/lib/internal/fs/promises.js b/lib/internal/fs/promises.js
@@ -376,21 +376,19 @@ async function chmod(path, mode) {
 }
 
 async function lchmod(path, mode) {
- if (O_SYMLINK !== undefined) {
- const fd = await open(path,
- O_WRONLY | O_SYMLINK);
- return fchmod(fd, mode).finally(fd.close.bind(fd));
- }
- throw new ERR_METHOD_NOT_IMPLEMENTED();
+ if (O_SYMLINK === undefined)
+ throw new ERR_METHOD_NOT_IMPLEMENTED();
+
+ const fd = await open(path, O_WRONLY | O_SYMLINK);
+ return fchmod(fd, mode).finally(fd.close.bind(fd));
 }
 
 async function lchown(path, uid, gid) {
- if (O_SYMLINK !== undefined) {
- const fd = await open(path,
- O_WRONLY | O_SYMLINK);
- return fchown(fd, uid, gid).finally(fd.close.bind(fd));
- }
- throw new ERR_METHOD_NOT_IMPLEMENTED();
+ if (O_SYMLINK === undefined)
+ throw new ERR_METHOD_NOT_IMPLEMENTED();
+
+ const fd = await open(path, O_WRONLY | O_SYMLINK);
+ return fchown(fd, uid, gid).finally(fd.close.bind(fd));
 }
 
 async function fchown(handle, uid, gid) {

-Original file line number
+Diff line change
+}
 asyncfunctionlchmod(path,mode){
 -if(O_SYMLINK!==undefined){
 -constfd=awaitopen(path,
 -O_WRONLY|O_SYMLINK);
 -returnfchmod(fd,mode).finally(fd.close.bind(fd));
 -}
 -thrownewERR_METHOD_NOT_IMPLEMENTED();
 +if(O_SYMLINK===undefined)
 +thrownewERR_METHOD_NOT_IMPLEMENTED();
++
 +constfd=awaitopen(path,O_WRONLY|O_SYMLINK);
 +returnfchmod(fd,mode).finally(fd.close.bind(fd));
+}
 asyncfunctionlchown(path,uid,gid){
 -if(O_SYMLINK!==undefined){
 -constfd=awaitopen(path,
 -O_WRONLY|O_SYMLINK);
 -returnfchown(fd,uid,gid).finally(fd.close.bind(fd));
 -}
 -thrownewERR_METHOD_NOT_IMPLEMENTED();
 +if(O_SYMLINK===undefined)
 +thrownewERR_METHOD_NOT_IMPLEMENTED();
++
 +constfd=awaitopen(path,O_WRONLY|O_SYMLINK);
 +returnfchown(fd,uid,gid).finally(fd.close.bind(fd));
+}
 asyncfunctionfchown(handle,uid,gid){