test: improve internet/test-dns

* change 'for' loop to 'for of' loop
* remove unused parameters passed to functions
* remove unnecessary 'assert.ok'
PR-URL: #24927
Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>

Author: IlarionHalushka

test/internet/test-dns.js

@@ -83,9 +83,7 @@ TEST(async function test_resolve4_ttl(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-assert.ok(item);
+for(constitemofresult){
 assert.strictEqual(typeofitem,'object');
 assert.strictEqual(typeofitem.ttl,'number');
 assert.strictEqual(typeofitem.address,'string');
@@ -113,9 +111,7 @@ TEST(async function test_resolve6_ttl(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-assert.ok(item);
+for(constitemofresult){
 assert.strictEqual(typeofitem,'object');
 assert.strictEqual(typeofitem.ttl,'number');
 assert.strictEqual(typeofitem.address,'string');
@@ -143,9 +139,7 @@ TEST(async function test_resolveMx(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-assert.ok(item);
+for(constitemofresult){
 assert.strictEqual(typeofitem,'object');
 assert.ok(item.exchange);
 assert.strictEqual(typeofitem.exchange,'string');
@@ -185,9 +179,7 @@ TEST(async function test_resolveNs(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-
+for(constitemofresult){
 assert.ok(item);
 assert.strictEqual(typeofitem,'string');
 }
@@ -225,14 +217,10 @@ TEST(async function test_resolveSrv(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-assert.ok(item);
+for(constitemofresult){
 assert.strictEqual(typeofitem,'object');
-
 assert.ok(item.name);
 assert.strictEqual(typeofitem.name,'string');
-
 assert.strictEqual(typeofitem.port,'number');
 assert.strictEqual(typeofitem.priority,'number');
 assert.strictEqual(typeofitem.weight,'number');
@@ -271,8 +259,7 @@ TEST(async function test_resolvePtr(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
+for(constitemofresult){
 assert.ok(item);
 assert.strictEqual(typeofitem,'string');
 }
@@ -310,9 +297,7 @@ TEST(async function test_resolveNaptr(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constitem=result[i];
-assert.ok(item);
+for(constitemofresult){
 assert.strictEqual(typeofitem,'object');
 assert.strictEqual(typeofitem.flags,'string');
 assert.strictEqual(typeofitem.service,'string');
@@ -353,7 +338,6 @@ TEST(function test_resolveNaptr_failure(done) {
 
 TEST(asyncfunctiontest_resolveSoa(done){
 functionvalidateResult(result){
-assert.ok(result);
 assert.strictEqual(typeofresult,'object');
 assert.strictEqual(typeofresult.nsname,'string');
 assert.ok(result.nsname.length>0);
@@ -403,10 +387,9 @@ TEST(async function test_resolveCname(done) {
 functionvalidateResult(result){
 assert.ok(result.length>0);
 
-for(leti=0;i<result.length;i++){
-constname=result[i];
-assert.ok(name);
-assert.strictEqual(typeofname,'string');
+for(constitemofresult){
+assert.ok(item);
+assert.strictEqual(typeofitem,'string');
 }
 }
 
@@ -480,7 +463,7 @@ TEST(function test_lookup_failure(done) {
 .then(common.mustNotCall())
 .catch(common.expectsError({errno: dns.NOTFOUND}));
 
-constreq=dns.lookup(addresses.INVALID_HOST,4,(err,ip,family)=>{
+constreq=dns.lookup(addresses.INVALID_HOST,4,(err)=>{
 assert.ok(errinstanceofError);
 assert.strictEqual(err.errno,dns.NOTFOUND);
 assert.strictEqual(err.errno,'ENOTFOUND');
@@ -548,7 +531,7 @@ TEST(function test_lookup_ip_promise(done) {
 TEST(asyncfunctiontest_lookup_null_all(done){
 assert.deepStrictEqual(awaitdnsPromises.lookup(null,{all: true}),[]);
 
-constreq=dns.lookup(null,{all: true},function(err,ips,family){
+constreq=dns.lookup(null,{all: true},(err,ips)=>{
 assert.ifError(err);
 assert.ok(Array.isArray(ips));
 assert.strictEqual(ips.length,0);
@@ -594,7 +577,7 @@ TEST(function test_lookupservice_invalid(done) {
 .then(common.mustNotCall())
 .catch(common.expectsError({code: 'ENOTFOUND'}));
 
-constreq=dns.lookupService('1.2.3.4',80,function(err,host,service){
+constreq=dns.lookupService('1.2.3.4',80,(err)=>{
 assert(errinstanceofError);
 assert.strictEqual(err.code,'ENOTFOUND');
 assert.ok(/1\.2\.3\.4/.test(err.message));