url: do not use object as hashmap

Fixes cases like new URLSearchParams({ hasOwnProperty: 1 }).
PR-URL: #47415
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Author: TimothyGu

lib/internal/url.js

@@ -20,6 +20,7 @@ const {
  ReflectGetOwnPropertyDescriptor,
  ReflectOwnKeys,
  RegExpPrototypeSymbolReplace,
+ SafeMap,
  StringPrototypeCharAt,
  StringPrototypeCharCodeAt,
  StringPrototypeCodePointAt,
@@ -243,7 +244,7 @@ class URLSearchParams {
 }else{
 // Record<USVString, USVString>
 // Need to use reflection APIs for full spec compliance.
-constvisited={};
+constvisited=newSafeMap();
 constkeys=ReflectOwnKeys(init);
 for(leti=0;i<keys.length;i++){
 constkey=keys[i];
@@ -252,14 +253,15 @@ class URLSearchParams {
 consttypedKey=toUSVString(key);
 consttypedValue=toUSVString(init[key]);
 
-// Two different key may result same after `toUSVString()`, we only
-// leave the later one. Refers to WPT.
-if(visited[typedKey]!==undefined){
-this[searchParams][visited[typedKey]]=typedValue;
+// Two different keys may become the same USVString after normalization.
+// In that case, we retain the later one. Refer to WPT.
+constkeyIdx=visited.get(typedKey);
+if(keyIdx!==undefined){
+this[searchParams][keyIdx]=typedValue;
 }else{
-visited[typedKey]=ArrayPrototypePush(this[searchParams],
-typedKey,
-typedValue)-1;
+visited.set(typedKey,ArrayPrototypePush(this[searchParams],
+typedKey,
+typedValue)-1);
 }
 }
 }

test/parallel/test-whatwg-url-custom-searchparams-constructor.js

@@ -38,8 +38,13 @@ function makeIterableFunc(array) {
 makeIterableFunc([['key','val'],['key2','val2']].map(makeIterableFunc))
 );
 assert.strictEqual(params.toString(),'key=val&key2=val2');
+params=newURLSearchParams({hasOwnProperty: 1});
+assert.strictEqual(params.get('hasOwnProperty'),'1');
+assert.strictEqual(params.toString(),'hasOwnProperty=1');
 assert.throws(()=>newURLSearchParams([[1]]),tupleError);
 assert.throws(()=>newURLSearchParams([[1,2,3]]),tupleError);
+assert.throws(()=>newURLSearchParams({[Symbol('test')]: 42}),
+TypeError);
 assert.throws(()=>newURLSearchParams({[Symbol.iterator]: 42}),
 iterableError);
 assert.throws(()=>newURLSearchParams([{}]),tupleError);