readline,repl,url,util: remove needless capturing

Use non-capturing grouping or remove capturing completely when:
* capturing is useless per se, e.g. in test() check;
* captured groups are not used afterwards at all;
* some of the later captured groups are not used afterwards.
PR-URL: #13718
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: vsemozhetbyt

lib/internal/url.js

@@ -51,7 +51,7 @@ const IteratorPrototype = Object.getPrototypeOf(
 );
 
 constunpairedSurrogateRe=
-/([^\uD800-\uDBFF]|^)[\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])/;
+/(?:[^\uD800-\uDBFF]|^)[\uDC00-\uDFFF]|[\uD800-\uDBFF](?![\uDC00-\uDFFF])/;
 functiontoUSVString(val){
 conststr=`${val}`;
 // As of V8 5.5, `str.search()` (and `unpairedSurrogateRe[@@search]()`) are

lib/readline.js

@@ -541,7 +541,7 @@ function commonPrefix(strings) {
 Interface.prototype._wordLeft=function(){
 if(this.cursor>0){
 varleading=this.line.slice(0,this.cursor);
-varmatch=leading.match(/([^\w\s]+|\w+|)\s*$/);
+varmatch=leading.match(/(?:[^\w\s]+|\w+|)\s*$/);
 this._moveCursor(-match[0].length);
 }
 };
@@ -550,7 +550,7 @@ Interface.prototype._wordLeft = function() {
 Interface.prototype._wordRight=function(){
 if(this.cursor<this.line.length){
 vartrailing=this.line.slice(this.cursor);
-varmatch=trailing.match(/^(\s+|\W+|\w+)\s*/);
+varmatch=trailing.match(/^(?:\s+|\W+|\w+)\s*/);
 this._moveCursor(match[0].length);
 }
 };
@@ -577,7 +577,7 @@ Interface.prototype._deleteRight = function() {
 Interface.prototype._deleteWordLeft=function(){
 if(this.cursor>0){
 varleading=this.line.slice(0,this.cursor);
-varmatch=leading.match(/([^\w\s]+|\w+|)\s*$/);
+varmatch=leading.match(/(?:[^\w\s]+|\w+|)\s*$/);
 leading=leading.slice(0,leading.length-match[0].length);
 this.line=leading+this.line.slice(this.cursor,this.line.length);
 this.cursor=leading.length;
@@ -589,7 +589,7 @@ Interface.prototype._deleteWordLeft = function() {
 Interface.prototype._deleteWordRight=function(){
 if(this.cursor<this.line.length){
 vartrailing=this.line.slice(this.cursor);
-varmatch=trailing.match(/^(\s+|\W+|\w+)\s*/);
+varmatch=trailing.match(/^(?:\s+|\W+|\w+)\s*/);
 this.line=this.line.slice(0,this.cursor)+
 trailing.slice(match[0].length);
 this._refreshLine();

lib/repl.js

@@ -679,9 +679,9 @@ ArrayStream.prototype.writable = true;
 ArrayStream.prototype.resume=function(){};
 ArrayStream.prototype.write=function(){};
 
-constrequireRE=/\brequire\s*\(['"](([\w@./-]+\/)?([\w@./-]*))/;
+constrequireRE=/\brequire\s*\(['"](([\w@./-]+\/)?(?:[\w@./-]*))/;
 constsimpleExpressionRE=
-/(([a-zA-Z_$](?:\w|\$)*)\.)*([a-zA-Z_$](?:\w|\$)*)\.?$/;
+/(?:[a-zA-Z_$](?:\w|\$)*\.)*[a-zA-Z_$](?:\w|\$)*\.?$/;
 
 functionintFilter(item){
 // filters out anything not starting with A-Z, a-z, $ or _
@@ -752,7 +752,7 @@ function complete(line, callback) {
 }elseif(match=line.match(requireRE)){
 // require('...<Tab>')
 constexts=Object.keys(this.context.require.extensions);
-varindexRe=newRegExp('^index('+exts.map(regexpEscape).join('|')+
+varindexRe=newRegExp('^index(?:'+exts.map(regexpEscape).join('|')+
 ')$');
 varversionedFileNamesRe=/-\d+\.\d+/;
 

lib/url.js

@@ -56,7 +56,7 @@ function Url() {
 
 // define these here so at least they only have to be
 // compiled once on the first module load.
-constprotocolPattern=/^([a-z0-9.+-]+:)/i;
+constprotocolPattern=/^[a-z0-9.+-]+:/i;
 constportPattern=/:[0-9]*$/;
 consthostPattern=/^\/\/[^@/]+@[^@/]+/;
 

lib/util.js

@@ -797,7 +797,7 @@ function formatProperty(ctx, value, recurseTimes, visibleKeys, key, array) {
 if(array){
 str=str.replace(/\n/g,'\n ');
 }else{
-str=str.replace(/(^|\n)/g,'\n ');
+str=str.replace(/^|\n/g,'\n ');
 }
 }
 }else{
@@ -809,13 +809,13 @@ function formatProperty(ctx, value, recurseTimes, visibleKeys, key, array) {
 returnstr;
 }
 name=JSON.stringify(''+key);
-if(/^"([a-zA-Z_][a-zA-Z_0-9]*)"$/.test(name)){
+if(/^"[a-zA-Z_][a-zA-Z_0-9]*"$/.test(name)){
 name=name.substr(1,name.length-2);
 name=ctx.stylize(name,'name');
 }else{
 name=name.replace(/'/g,"\\'")
 .replace(/\\"/g,'"')
-.replace(/(^"|"$)/g,"'")
+.replace(/^"|"$/g,"'")
 .replace(/\\\\/g,'\\');
 name=ctx.stylize(name,'string');
 }