test: use worker.exitedAfterDisconnect consistently

PR-URL: #13702
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Sam Roberts <vieuxtech@gmail.com>
Reviewed-By: Tobias Nießen <tniessen@tnie.de>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: jasnell

test/parallel/test-cluster-worker-constructor.js

@@ -29,7 +29,7 @@ const cluster = require('cluster');
 letworker;
 
 worker=newcluster.Worker();
-assert.strictEqual(worker.suicide,undefined);
+assert.strictEqual(worker.exitedAfterDisconnect,undefined);
 assert.strictEqual(worker.state,'none');
 assert.strictEqual(worker.id,0);
 assert.strictEqual(worker.process,undefined);
@@ -39,7 +39,7 @@ worker = new cluster.Worker({
 state: 'online',
 process: process
 });
-assert.strictEqual(worker.suicide,undefined);
+assert.strictEqual(worker.exitedAfterDisconnect,undefined);
 assert.strictEqual(worker.state,'online');
 assert.strictEqual(worker.id,3);
 assert.strictEqual(worker.process,process);

test/parallel/test-cluster-worker-deprecated.js

@@ -29,12 +29,8 @@ if (cluster.isWorker) {
 http.Server(()=>{
 
 }).listen(0,'127.0.0.1');
-constworker=cluster.worker;
-assert.strictEqual(worker.exitedAfterDisconnect,worker.suicide);
 
 cluster.worker.on('disconnect',common.mustCall(()=>{
-assert.strictEqual(cluster.worker.exitedAfterDisconnect,
-cluster.worker.suicide);
 process.exit(42);
 }));
 

test/parallel/test-cluster-worker-disconnect.js

@@ -52,7 +52,6 @@ if (cluster.isWorker) {
 worker_emitDisconnect: [1,"the worker did not emit 'disconnect'"],
 worker_emitExit: [1,"the worker did not emit 'exit'"],
 worker_state: ['disconnected','the worker state is incorrect'],
-worker_suicideMode: [false,'the worker.suicide flag is incorrect'],
 worker_exitedAfterDisconnect: [
 false,'the .exitedAfterDisconnect flag is incorrect'
 ],
@@ -84,7 +83,6 @@ if (cluster.isWorker) {
 // Check worker events and properties
 worker.on('disconnect',common.mustCall(()=>{
 results.worker_emitDisconnect+=1;
-results.worker_suicideMode=worker.suicide;
 results.worker_exitedAfterDisconnect=worker.exitedAfterDisconnect;
 results.worker_state=worker.state;
 if(results.worker_emitExit>0){

test/parallel/test-cluster-worker-exit.js

@@ -7,11 +7,11 @@ if (cluster.isMaster) {
 functionforkWorker(action){
 constworker=cluster.fork({ action });
 worker.on('disconnect',common.mustCall(()=>{
-assert.strictEqual(worker.suicide,true);
+assert.strictEqual(worker.exitedAfterDisconnect,true);
 }));
 
 worker.on('exit',common.mustCall(()=>{
-assert.strictEqual(worker.suicide,true);
+assert.strictEqual(worker.exitedAfterDisconnect,true);
 }));
 }