http: add CONNECT method handling for default Host header with proxy

Signed-off-by: Archkon <180910180+Archkon@users.noreply.github.com>
PR-URL: #64114Fixes: #63945
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Reviewed-By: Tim Perry <pimterry@gmail.com>

Author: Archkon

lib/_http_client.js

@@ -526,7 +526,9 @@ function ClientRequest(input, options, cb) {
 constuserHostHeader=this.getHeader('host');
 
 if(host&&!this.getHeader('host')&&setHost){
-this.setHeader('Host',hostHeaderFromOptions);
+consthostHeader=method==='CONNECT'&&options.path ?
+String(this.path) : hostHeaderFromOptions;
+this.setHeader('Host',hostHeader);
 }
 
 if(options.auth&&!this.getHeader('Authorization')){

test/parallel/test-http-connect-default-host-header.js

@@ -0,0 +1,37 @@
+'use strict';
+
+constcommon=require('../common');
+constassert=require('assert');
+consthttp=require('http');
+constnet=require('net');
+
+consttarget='target.example.com:443';
+
+constserver=net.createServer(common.mustCall((socket)=>{
+socket.once('data',common.mustCall((data)=>{
+constrawRequest=data.toString();
+constrequestLines=rawRequest.split('\r\n');
+
+assert.strictEqual(requestLines[0],`CONNECT ${target} HTTP/1.1`);
+assert(requestLines.includes(`Host: ${target}`));
+
+socket.end('HTTP/1.1 200 Connection established\r\n\r\n');
+}));
+}));
+
+server.listen(0,common.localhostIPv4,common.mustCall(()=>{
+constreq=http.request({
+host: common.localhostIPv4,
+port: server.address().port,
+method: 'CONNECT',
+path: target,
+},common.mustNotCall());
+
+req.on('connect',common.mustCall((res,socket)=>{
+assert.strictEqual(res.statusCode,200);
+socket.destroy();
+server.close();
+}));
+
+req.end();
+}));

test/parallel/test-tls-over-http-tunnel.js

@@ -61,7 +61,7 @@ const proxy = net.createServer(common.mustCall((clientSocket) => {
 `CONNECT localhost:${server.address().port} `+
 'HTTP/1.1\r\n'+
 'Proxy-Connections: keep-alive\r\n'+
-`Host: localhost:${proxy.address().port}\r\n`+
+`Host: localhost:${server.address().port}\r\n`+
 'Connection: keep-alive\r\n\r\n');
 
 console.log('PROXY: got CONNECT request');