lib: replace charCodeAt with fixed Unicode

PR-URL: #32758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
Reviewed-By: Zeyu Yang <himself65@outlook.com>

Author: rickyes

lib/internal/console/constructor.js

@@ -42,13 +42,19 @@ const {
 const{
  isTypedArray, isSet, isMap, isSetIterator, isMapIterator,
 }=require('internal/util/types');
+const{
+CHAR_LOWERCASE_B,
+CHAR_LOWERCASE_E,
+CHAR_LOWERCASE_N,
+CHAR_UPPERCASE_C,
+}=require('internal/constants');
 constkCounts=Symbol('counts');
 
 constkTraceConsoleCategory='node,node.console';
-constkTraceCount='C'.charCodeAt(0);
-constkTraceBegin='b'.charCodeAt(0);
-constkTraceEnd='e'.charCodeAt(0);
-constkTraceInstant='n'.charCodeAt(0);
+constkTraceCount=CHAR_UPPERCASE_C;
+constkTraceBegin=CHAR_LOWERCASE_B;
+constkTraceEnd=CHAR_LOWERCASE_E;
+constkTraceInstant=CHAR_LOWERCASE_N;
 
 constkSecond=1000;
 constkMinute=60*kSecond;

lib/internal/constants.js

@@ -8,6 +8,10 @@ module.exports = {
 CHAR_LOWERCASE_A: 97,/* a */
 CHAR_UPPERCASE_Z: 90,/* Z */
 CHAR_LOWERCASE_Z: 122,/* z */
+CHAR_UPPERCASE_C: 67,/* C */
+CHAR_LOWERCASE_B: 98,/* b */
+CHAR_LOWERCASE_E: 101,/* e */
+CHAR_LOWERCASE_N: 110,/* n */
 
 // Non-alphabetic chars.
 CHAR_DOT: 46,/* . */

lib/internal/trace_events_async_hooks.js

@@ -10,12 +10,16 @@ const {
 const{ trace }=internalBinding('trace_events');
 constasync_wrap=internalBinding('async_wrap');
 constasync_hooks=require('async_hooks');
+const{
+CHAR_LOWERCASE_B,
+CHAR_LOWERCASE_E,
+}=require('internal/constants');
 
 // Use small letters such that chrome://tracing groups by the name.
 // The behavior is not only useful but the same as the events emitted using
 // the specific C++ macros.
-constkBeforeEvent='b'.charCodeAt(0);
-constkEndEvent='e'.charCodeAt(0);
+constkBeforeEvent=CHAR_LOWERCASE_B;
+constkEndEvent=CHAR_LOWERCASE_E;
 constkTraceEventCategory='node,node.async_hooks';
 
 constkEnabled=Symbol('enabled');