test: ensure that all worker servers are ready

lpinca · aduh95 · commit ed080d868db6 · 2024-04-29T22:46:26.000+02:00
Wait for the `'listening'` message from all workers before creating the first connection. This fixes an `EMFILE` error that is raised on Windows when running the following command ``` python tools/test.py -J --repeat=1000 parallel/test-tls-ticket-cluster ``` PR-URL: #52563 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Marco Ippolito <marcoippolito54@gmail.com> Reviewed-By: Yagiz Nizipli <yagiz.nizipli@sentry.io> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
diff --git a/test/parallel/test-tls-ticket-cluster.js b/test/parallel/test-tls-ticket-cluster.js
@@ -33,10 +33,10 @@ const workerCount = 4;
 const expectedReqCount = 16;
 
 if (cluster.isPrimary) {
+ let listeningCount = 0;
 let reusedCount = 0;
 let reqCount = 0;
 let lastSession = null;
- let shootOnce = false;
 let workerPort = null;
 
 function shoot() {
@@ -73,9 +73,8 @@ if (cluster.isPrimary) {
 console.error('[primary] got %j', msg);
 if (msg === 'reused') {
 ++reusedCount;
- } else if (msg === 'listening' && !shootOnce) {
- workerPort = port || workerPort;
- shootOnce = true;
+ } else if (msg === 'listening' && ++listeningCount === workerCount) {
+ workerPort = port;
 shoot();
 }
 });

-Original file line number
+Diff line change
 constexpectedReqCount=16;
 if(cluster.isPrimary){
 +letlisteningCount=0;
 letreusedCount=0;
 letreqCount=0;
 letlastSession=null;
 -letshootOnce=false;
 letworkerPort=null;
 functionshoot(){
 console.error('[primary] got %j',msg);
 if(msg==='reused'){
 ++reusedCount;
 -}elseif(msg==='listening'&&!shootOnce){
 -workerPort=port||workerPort;
 -shootOnce=true;
 +}elseif(msg==='listening'&&++listeningCount===workerCount){
 +workerPort=port;
 shoot();
+}
 });