src: update inspector code to match upstream API

targos · targos · commit ed12ea371c53 · 2017-03-25T09:44:12.000+01:00
PR-URL: #11752 Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com>
diff --git a/src/inspector_agent.cc b/src/inspector_agent.cc
@@ -234,12 +234,15 @@ class ChannelImpl final : public v8_inspector::V8Inspector::Channel {
 explicit ChannelImpl(AgentImpl* agent): agent_(agent) {}
 virtual ~ChannelImpl() {}
 private:
- void sendProtocolResponse(int callId, const StringView& message) override {
- sendMessageToFrontend(message);
+ void sendResponse(
+ int callId,
+ std::unique_ptr<v8_inspector::StringBuffer> message) override {
+ sendMessageToFrontend(message->string());
 }
 
- void sendProtocolNotification(const StringView& message) override {
- sendMessageToFrontend(message);
+ void sendNotification(
+ std::unique_ptr<v8_inspector::StringBuffer> message) override {
+ sendMessageToFrontend(message->string());
 }
 
 void flushProtocolNotifications() override { }

-Original file line number
+Diff line change
 explicitChannelImpl(AgentImpl* agent): agent_(agent) {}
 virtual~ChannelImpl() {}
 private:
 -voidsendProtocolResponse(int callId, const StringView& message) override {
 -sendMessageToFrontend(message);
 +voidsendResponse(
 +int callId,
 + std::unique_ptr<v8_inspector::StringBuffer> message) override {
 +sendMessageToFrontend(message->string());
+ }
 -voidsendProtocolNotification(const StringView& message) override {
 -sendMessageToFrontend(message);
 +voidsendNotification(
 + std::unique_ptr<v8_inspector::StringBuffer> message) override {
 +sendMessageToFrontend(message->string());
+ }
 voidflushProtocolNotifications() override { }