Skip to content

Commit eda7fff

Browse files
sohailrajdev97targos
authored andcommitted
test: swap arguments in strictEqual()
This commit also comments the third argument PR-URL: #21660 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Gus Caplan <me@gus.host> Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: Trivikram Kamat <trivikr.dev@gmail.com>
1 parent 194d195 commit eda7fff

1 file changed

Lines changed: 15 additions & 14 deletions

File tree

‎test/pummel/test-timers.js‎

Lines changed: 15 additions & 14 deletions
Original file line numberDiff line numberDiff line change
@@ -31,7 +31,7 @@ let interval_count = 0;
3131
clearTimeout(null);
3232
clearInterval(null);
3333

34-
assert.strictEqual(true,setTimeoutinstanceofFunction);
34+
assert.strictEqual(setTimeoutinstanceofFunction,true);
3535
conststarttime=newDate();
3636
setTimeout(common.mustCall(function(){
3737
constendtime=newDate();
@@ -40,7 +40,7 @@ setTimeout(common.mustCall(function() {
4040
assert.ok(diff>0);
4141
console.error(`diff: ${diff}`);
4242

43-
assert.strictEqual(true,1000-WINDOW<diff&&diff<1000+WINDOW);
43+
assert.strictEqual(1000-WINDOW<diff&&diff<1000+WINDOW,true);
4444
}),1000);
4545

4646
// this timer shouldn't execute
@@ -57,23 +57,23 @@ setInterval(function() {
5757

5858
constt=interval_count*1000;
5959

60-
assert.strictEqual(true,t-WINDOW<diff&&diff<t+WINDOW);
60+
assert.strictEqual(t-WINDOW<diff&&diff<t+WINDOW,true);
6161

62-
assert.strictEqual(true,interval_count<=3);
62+
assert.strictEqual(interval_count<=3,true);
6363
if(interval_count===3)
6464
clearInterval(this);
6565
},1000);
6666

6767

6868
// Single param:
6969
setTimeout(function(param){
70-
assert.strictEqual('test param',param);
70+
assert.strictEqual(param,'test param');
7171
},1000,'test param');
7272

7373
letinterval_count2=0;
7474
setInterval(function(param){
7575
++interval_count2;
76-
assert.strictEqual('test param',param);
76+
assert.strictEqual(param,'test param');
7777

7878
if(interval_count2===3)
7979
clearInterval(this);
@@ -82,15 +82,15 @@ setInterval(function(param) {
8282

8383
// Multiple param
8484
setTimeout(function(param1,param2){
85-
assert.strictEqual('param1',param1);
86-
assert.strictEqual('param2',param2);
85+
assert.strictEqual(param1,'param1');
86+
assert.strictEqual(param2,'param2');
8787
},1000,'param1','param2');
8888

8989
letinterval_count3=0;
9090
setInterval(function(param1,param2){
9191
++interval_count3;
92-
assert.strictEqual('param1',param1);
93-
assert.strictEqual('param2',param2);
92+
assert.strictEqual(param1,'param1');
93+
assert.strictEqual(param2,'param2');
9494

9595
if(interval_count3===3)
9696
clearInterval(this);
@@ -120,8 +120,9 @@ clearTimeout(y);
120120

121121

122122
process.on('exit',function(){
123-
assert.strictEqual(3,interval_count);
124-
assert.strictEqual(11,count4);
125-
assert.strictEqual(0,expectedTimeouts,
126-
'clearTimeout cleared too many timeouts');
123+
assert.strictEqual(interval_count,3);
124+
assert.strictEqual(count4,11);
125+
126+
// Check that the correct number of timers ran.
127+
assert.strictEqual(expectedTimeouts,0);
127128
});

0 commit comments

Comments
 (0)