cluster, dns, repl, tls, util: fix RegExp nits

* Take RegExp creation out of cycles.
* Use test(), not match() in boolean context.
* Remove redundant RegExp parts.
Backport-PR-URL: #14348
PR-URL: #13536
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Author: vsemozhetbyt

lib/_tls_wrap.js

@@ -954,7 +954,7 @@ function SNICallback(servername, callback) {
 varctx;
 
 this.server._contexts.some(function(elem){
-if(servername.match(elem[0])!==null){
+if(elem[0].test(servername)){
 ctx=elem[1];
 returntrue;
 }

lib/cluster.js

@@ -298,14 +298,13 @@ function masterInit() {
 varworkerEnv=util._extend({},process.env);
 varexecArgv=cluster.settings.execArgv.slice();
 vardebugPort=0;
+vardebugArgvRE=/^(--inspect|--debug|--debug-(brk|port))(=\d+)?$/;
 
 workerEnv=util._extend(workerEnv,env);
 workerEnv.NODE_UNIQUE_ID=''+id;
 
 for(vari=0;i<execArgv.length;i++){
-varmatch=execArgv[i].match(
-/^(--inspect|--debug|--debug-(brk|port))(=\d+)?$/
-);
+varmatch=execArgv[i].match(debugArgvRE);
 
 if(match){
 if(debugPort===0){

lib/dns.js

@@ -297,21 +297,23 @@ exports.setServers = function(servers) {
 // servers cares won't have any servers available for resolution
 constorig=cares.getServers();
 constnewSet=[];
+constIPv6RE=/\[(.*)\]/;
+constaddrSplitRE=/:\d+$/;
 
 servers.forEach((serv)=>{
 varipVersion=isIP(serv);
 if(ipVersion!==0)
 returnnewSet.push([ipVersion,serv]);
 
-constmatch=serv.match(/\[(.*)\](?::\d+)?/);
+constmatch=serv.match(IPv6RE);
 // we have an IPv6 in brackets
 if(match){
 ipVersion=isIP(match[1]);
 if(ipVersion!==0)
 returnnewSet.push([ipVersion,match[1]]);
 }
 
-consts=serv.split(/:\d+$/)[0];
+consts=serv.split(addrSplitRE)[0];
 ipVersion=isIP(s);
 
 if(ipVersion!==0)

lib/repl.js

@@ -861,6 +861,7 @@ function complete(line, callback) {
 constexts=Object.keys(this.context.require.extensions);
 varindexRe=newRegExp('^index('+exts.map(regexpEscape).join('|')+
 ')$');
+varversionedFileNamesRe=/-\d+\.\d+/;
 
 completeOn=match[1];
 varsubdir=match[2]||'';
@@ -879,7 +880,7 @@ function complete(line, callback) {
 name=files[f];
 ext=path.extname(name);
 base=name.slice(0,-ext.length);
-if(base.match(/-\d+\.\d+(\.\d+)?/)||name==='.npm'){
+if(versionedFileNamesRe.test(base)||name==='.npm'){
 // Exclude versioned names that 'npm' installs.
 continue;
 }
@@ -923,7 +924,7 @@ function complete(line, callback) {
 // spam.eggs.<|> # completions for 'spam.eggs' with filter ''
 // foo<|> # all scope vars with filter 'foo'
 // foo.<|> # completions for 'foo' with filter ''
-}elseif(line.length===0||line[line.length-1].match(/\w|\.|\$/)){
+}elseif(line.length===0||/\w|\.|\$/.test(line[line.length-1])){
 match=simpleExpressionRE.exec(line);
 if(line.length===0||match){
 varexpr;
@@ -1175,7 +1176,7 @@ REPLServer.prototype.memory = function memory(cmd) {
 self.lines.level.push({
 line: self.lines.length-1,
 depth: depth,
-isFunction: /\s*function\s*/.test(cmd)
+isFunction: /\bfunction\b/.test(cmd)
 });
 }elseif(depth<0){
 // going... up.

lib/util.js

@@ -17,6 +17,8 @@ const inspectDefaultOptions = Object.seal({
 breakLength: 60
 });
 
+constnumbersOnlyRE=/^\d+$/;
+
 varDebug;
 varsimdFormatters;
 
@@ -668,7 +670,7 @@ function formatArray(ctx, value, recurseTimes, visibleKeys, keys) {
 output.push(`... ${remaining} more item${remaining>1 ? 's' : ''}`);
 }
 keys.forEach(function(key){
-if(typeofkey==='symbol'||!key.match(/^\d+$/)){
+if(typeofkey==='symbol'||!numbersOnlyRE.test(key)){
 output.push(formatProperty(ctx,value,recurseTimes,visibleKeys,
 key,true));
 }
@@ -687,7 +689,7 @@ function formatTypedArray(ctx, value, recurseTimes, visibleKeys, keys) {
 output.push(`... ${remaining} more item${remaining>1 ? 's' : ''}`);
 }
 for(constkeyofkeys){
-if(typeofkey==='symbol'||!key.match(/^\d+$/)){
+if(typeofkey==='symbol'||!numbersOnlyRE.test(key)){
 output.push(
 formatProperty(ctx,value,recurseTimes,visibleKeys,key,true));
 }
@@ -801,11 +803,11 @@ function formatProperty(ctx, value, recurseTimes, visibleKeys, key, array) {
 }
 }
 if(name===undefined){
-if(array&&key.match(/^\d+$/)){
+if(array&&numbersOnlyRE.test(key)){
 returnstr;
 }
 name=JSON.stringify(''+key);
-if(name.match(/^"([a-zA-Z_][a-zA-Z_0-9]*)"$/)){
+if(/^"([a-zA-Z_][a-zA-Z_0-9]*)"$/.test(name)){
 name=name.substr(1,name.length-2);
 name=ctx.stylize(name,'name');
 }else{