test: deflake test-perf-hooks-timerify-histogram-sync

The previous busy loop wasn't robust enough in making sure
that the function runs for more than 1 nanosecond - and when it
runs faster than that on a fast machine, it measures to 0 for
nanosecond precision and throws a RangeErorr as histogram.record()
only takes positive values. Update it to use Atomics.wait() to
make sure that the function being measured runs for at least
1 millisecond so that the histogram always records a positive value.
PR-URL: #60639Fixes: #60638
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>

Author: joyeecheung

test/common/index.js

@@ -931,6 +931,12 @@ function expectRequiredTLAError(err) {
 }
 }
 
+functionsleepSync(ms){
+constsab=newSharedArrayBuffer(4);
+consti32=newInt32Array(sab);
+Atomics.wait(i32,0,0,ms);
+}
+
 constcommon={
  allowGlobals,
  buildType,
@@ -982,6 +988,7 @@ const common = {
  skipIfInspectorDisabled,
  skipIfSQLiteMissing,
  spawnPromisified,
+ sleepSync,
 
 getenoughTestMem(){
 returnrequire('os').totalmem()>0x70000000;/* 1.75 Gb */

test/common/index.mjs

@@ -50,6 +50,7 @@ const {
  skipIfInspectorDisabled,
  skipIfSQLiteMissing,
  spawnPromisified,
+ sleepSync,
 }=common;
 
 constgetPort=()=>common.PORT;
@@ -103,4 +104,5 @@ export {
 skipIfInspectorDisabled,
 skipIfSQLiteMissing,
 spawnPromisified,
+sleepSync,
 };

test/parallel/test-perf-hooks-timerify-histogram-sync.mjs

@@ -1,22 +1,19 @@
 // Test that timerify works with histogram option for synchronous functions.
 
-import'../common/index.mjs';
+import{sleepSync}from'../common/index.mjs';
 importassertfrom'assert';
 import{createHistogram,timerify}from'perf_hooks';
-import{setTimeoutassleep}from'timers/promises';
-
-let_deadCode;
 
 consthistogram=createHistogram();
-constm=(a,b=1)=>{
-for(leti=0;i<1e3;i++)
-_deadCode=i;
+
+constm=()=>{
+// Deterministic blocking delay (~1 millisecond). The histogram operates on
+// nanosecond precision, so this should be sufficient to prevent zero timings.
+sleepSync(1);
 };
 constn=timerify(m,{ histogram });
 assert.strictEqual(histogram.max,0);
 for(leti=0;i<10;i++){
 n();
-awaitsleep(10);
 }
-assert(_deadCode>=0);
 assert.notStrictEqual(histogram.max,0);