Skip to content

Commit ef3698c

Browse files
cjihrigMylesBorins
authored andcommitted
test: refactor test-cluster-worker-isconnected.js
PR-URL: #13685 Reviewed-By: Refael Ackermann <refack@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: David Cai <davidcai1993@yahoo.com> Reviewed-By: Daniel Bevenius <daniel.bevenius@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
1 parent fa75be7 commit ef3698c

1 file changed

Lines changed: 11 additions & 19 deletions

File tree

Lines changed: 11 additions & 19 deletions
Original file line numberDiff line numberDiff line change
@@ -1,38 +1,30 @@
11
'use strict';
2-
require('../common');
2+
constcommon=require('../common');
33
constcluster=require('cluster');
44
constassert=require('assert');
55

66
if(cluster.isMaster){
77
constworker=cluster.fork();
88

9-
assert.ok(worker.isConnected(),
10-
'isConnected() should return true as soon as the worker has '+
11-
'been created.');
9+
assert.strictEqual(worker.isConnected(),true);
1210

13-
worker.on('disconnect',function(){
14-
assert.ok(!worker.isConnected(),
15-
'After a disconnect event has been emitted, '+
16-
'isConncted should return false');
17-
});
11+
worker.on('disconnect',common.mustCall(()=>{
12+
assert.strictEqual(worker.isConnected(),false);
13+
}));
1814

1915
worker.on('message',function(msg){
2016
if(msg==='readyToDisconnect'){
2117
worker.disconnect();
2218
}
2319
});
24-
2520
}else{
26-
assert.ok(cluster.worker.isConnected(),
27-
'isConnected() should return true from within a worker at all '+
28-
'times.');
21+
functionassertNotConnected(){
22+
assert.strictEqual(cluster.worker.isConnected(),false);
23+
}
2924

30-
cluster.worker.process.on('disconnect',function(){
31-
assert.ok(!cluster.worker.isConnected(),
32-
'isConnected() should return false from within a worker '+
33-
'after its underlying process has been disconnected from '+
34-
'the master');
35-
});
25+
assert.strictEqual(cluster.worker.isConnected(),true);
26+
cluster.worker.on('disconnect',common.mustCall(assertNotConnected));
27+
cluster.worker.process.on('disconnect',common.mustCall(assertNotConnected));
3628

3729
process.send('readyToDisconnect');
3830
}

0 commit comments

Comments
 (0)