assert: add partial support for evaluated code in simple assert

This makes sure using `assert.ok()` in `new Function()` statements
visualizes the actual call site in the error message.
PR-URL: #27781
Reviewed-By: Rich Trott <rtrott@gmail.com>

Author: BridgeAR

lib/assert.js

@@ -269,24 +269,31 @@ function getErrMessage(message, fn) {
 Error.prepareStackTrace=tmpPrepare;
 
 constfilename=call.getFileName();
-
-if(!filename){
-returnmessage;
-}
-
 constline=call.getLineNumber()-1;
 letcolumn=call.getColumnNumber()-1;
+letidentifier;
+letcode;
 
-constidentifier=`${filename}${line}${column}`;
+if(filename){
+identifier=`${filename}${line}${column}`;
 
-if(errorCache.has(identifier)){
-returnerrorCache.get(identifier);
+// Skip Node.js modules!
+if(filename.endsWith('.js')&&
+NativeModule.exists(filename.slice(0,-3))){
+errorCache.set(identifier,undefined);
+return;
+}
+}else{
+constfn=call.getFunction();
+if(!fn){
+returnmessage;
+}
+code=String(fn);
+identifier=`${code}${line}${column}`;
 }
 
-// Skip Node.js modules!
-if(filename.endsWith('.js')&&NativeModule.exists(filename.slice(0,-3))){
-errorCache.set(identifier,undefined);
-return;
+if(errorCache.has(identifier)){
+returnerrorCache.get(identifier);
 }
 
 letfd;
@@ -295,16 +302,22 @@ function getErrMessage(message, fn) {
 // errors are handled faster.
 Error.stackTraceLimit=0;
 
-if(decoder===undefined){
-const{ StringDecoder }=require('string_decoder');
-decoder=newStringDecoder('utf8');
+if(filename){
+if(decoder===undefined){
+const{ StringDecoder }=require('string_decoder');
+decoder=newStringDecoder('utf8');
+}
+fd=openSync(filename,'r',0o666);
+// Reset column and message.
+[column,message]=getCode(fd,line,column);
+// Flush unfinished multi byte characters.
+decoder.end();
+}else{
+for(leti=0;i<line;i++){
+code=code.slice(code.indexOf('\n')+1);
+}
+[column,message]=parseCode(code,column);
 }
-
-fd=openSync(filename,'r',0o666);
-// Reset column and message.
-[column,message]=getCode(fd,line,column);
-// Flush unfinished multi byte characters.
-decoder.end();
 // Always normalize indentation, otherwise the message could look weird.
 if(message.includes('\n')){
 if(EOL==='\r\n'){

test/parallel/test-assert.js

@@ -858,6 +858,13 @@ common.expectsError(
 {
 code: 'ERR_ASSERTION',
 type: assert.AssertionError,
+message: 'The expression evaluated to a falsy value:\n\n assert(1 === 2)\n'
+}
+);
+assert.throws(
+()=>eval('console.log("FOO");\nassert.ok(1 === 2);'),
+{
+code: 'ERR_ASSERTION',
 message: 'false == true'
 }
 );