fs: ensure readdir() callback is only called once

This commit ensures that the readdir() callback can only be
called once when the withFileTypes parameter is supplied.
PR-URL: #22793Fixes: #22778
Reviewed-By: Bryan English <bryan@bryanenglish.com>
Reviewed-By: Anatoli Papirovski <apapirovski@mac.com>
Reviewed-By: Minwoo Jung <minwoo@nodesource.com>

Author: cjihrig

lib/internal/fs/utils.js

@@ -10,6 +10,7 @@ const {
 ERR_OUT_OF_RANGE
 }=require('internal/errors').codes;
 const{ isUint8Array, isArrayBufferView }=require('internal/util/types');
+const{ once }=require('internal/util');
 constpathModule=require('path');
 constutil=require('util');
 constkType=Symbol('type');
@@ -123,6 +124,7 @@ function getDirents(path, [names, types], callback) {
 if(typeofcallback=='function'){
 constlen=names.length;
 lettoFinish=0;
+callback=once(callback);
 for(i=0;i<len;i++){
 consttype=types[i];
 if(type===UV_DIRENT_UNKNOWN){

lib/internal/streams/pipeline.js

@@ -5,20 +5,12 @@
 
 leteos;
 
+const{ once }=require('internal/util');
 const{
 ERR_MISSING_ARGS,
 ERR_STREAM_DESTROYED
 }=require('internal/errors').codes;
 
-functiononce(callback){
-letcalled=false;
-returnfunction(err){
-if(called)return;
-called=true;
-callback(err);
-};
-}
-
 functionnoop(err){
 // Rethrow the error if it exists to avoid swallowing it
 if(err)throwerr;

lib/internal/util.js

@@ -364,6 +364,15 @@ function isInsideNodeModules() {
 returnfalse;
 }
 
+functiononce(callback){
+letcalled=false;
+returnfunction(...args){
+if(called)return;
+called=true;
+callback(...args);
+};
+}
+
 module.exports={
  assertCrypto,
  cachedResult,
@@ -380,6 +389,7 @@ module.exports = {
  join,
  normalizeEncoding,
  objectToString,
+ once,
  promisify,
  spliceOne,
  removeColors,